Skip to content

Commit db9cbef

Browse files
GCHOfficialclaude
andauthored
fix(ci): re-add Kotlin to CodeQL (#32); bump Flutter 3.44.5 + supabase_flutter 2.16.0 (#85)
CodeQL CLI 2.26.0 / codeql-bundle-v2.26.0 (published 2026-07-08) ships the Kotlin 2.4.0 support merged in github/codeql#21970, so codeql-action@v4 no longer aborts with "Kotlin version 2.4.0 is too recent". Re-add the java-kotlin matrix entry (build-mode manual: setup-java temurin 17 + flutter build apk --debug, checkout with LFS for the libdovi AAR) and refresh the header comment to document the >= v2.26.0 bundle requirement. Also bump the Flutter pin 3.44.4 -> 3.44.5 across build/codeql/release workflows and upgrade supabase_flutter 2.15.4 -> 2.16.0 (supabase 2.14.0, gotrue 2.26.0, realtime_client 2.11.0, passkeys_platform_interface 2.8.0). flutter analyze clean; flutter test 141/141 pass. Closes #32 Claude-Session: https://claude.ai/code/session_01Pf76uZnruw81CCGZo1pQFo Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
1 parent ab8631b commit db9cbef

4 files changed

Lines changed: 43 additions & 22 deletions

File tree

.github/workflows/build.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ permissions:
1717
contents: read
1818

1919
env:
20-
FLUTTER_VERSION: 3.44.4
20+
FLUTTER_VERSION: 3.44.5
2121

2222
jobs:
2323
# Fast gate: static analysis + the pure-logic / persistence unit tests. Always

.github/workflows/codeql.yml

Lines changed: 31 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -9,22 +9,22 @@ on:
99
- cron: '23 5 * * 1' # weekly, Monday 05:23 UTC
1010

1111
# CodeQL doesn't support Dart (the bulk of lib/), so this covers the native code
12-
# it can: the Windows-runner C++ (GDI overlay, HDR badges) and the workflow YAML.
12+
# it can: the Windows-runner C++ (GDI overlay, HDR badges), the Android Kotlin
13+
# (native HDR player / preview engine), and the workflow YAML.
14+
#
15+
# java-kotlin needs a CodeQL CLI that accepts the app's Kotlin (2.4.0). That
16+
# landed in CLI 2.26.0 / codeql-bundle-v2.26.0 (github/codeql#21970) — earlier
17+
# CLIs aborted with "Kotlin version 2.4.0 is too recent". The pinned
18+
# codeql-action major (@v4) must therefore resolve to a bundle >= v2.26.0.
1319
#
1420
# Not covered:
15-
# - java-kotlin (the Android player/HDR code): the app is on Kotlin 2.4.0, and
16-
# the latest released CodeQL CLI (2.25.6) still caps at < 2.3.30 ("Kotlin
17-
# version 2.4.0 is too recent"). Support is merged upstream
18-
# (github/codeql#21970) but not yet in a CLI release. Re-add a
19-
# `{language: java-kotlin, build-mode: manual}` entry (with setup-java +
20-
# `flutter build apk` + `lfs: true`) once a CLI past 2.25.6 ships it.
2121
# - javascript-typescript: web/ is only Flutter's generated bootstrap (no source).
2222
# - swift: the iOS/macOS shells are Flutter template code (no first-party logic).
2323
permissions:
2424
contents: read
2525

2626
env:
27-
FLUTTER_VERSION: 3.44.4
27+
FLUTTER_VERSION: 3.44.5
2828

2929
jobs:
3030
analyze:
@@ -42,33 +42,54 @@ jobs:
4242
- language: c-cpp
4343
build-mode: manual
4444
runner: windows-latest
45+
- language: java-kotlin
46+
build-mode: manual
47+
runner: ubuntu-latest
4548
- language: actions
4649
build-mode: none
4750
runner: ubuntu-latest
4851
steps:
4952
- uses: actions/checkout@v7
53+
with:
54+
# The Android build links the libdovi libmpv AAR, which lives in Git LFS
55+
# (android/app/libs/libmpv-dovi.aar); other languages don't need it.
56+
lfs: ${{ matrix.language == 'java-kotlin' }}
5057

5158
- uses: github/codeql-action/init@v4
5259
with:
5360
languages: ${{ matrix.language }}
5461
build-mode: ${{ matrix.build-mode }}
5562

56-
# C++ is Flutter-driven, so CodeQL's autobuild can't build it — run the real
57-
# Flutter build under build-mode manual so the tracer sees the compiler.
63+
# Both native builds are Flutter-driven, so CodeQL's autobuild can't build
64+
# them — run the real Flutter build under build-mode manual so the tracer
65+
# sees the compiler.
5866
- if: matrix.build-mode == 'manual'
5967
uses: subosito/flutter-action@v2
6068
with:
6169
flutter-version: ${{ env.FLUTTER_VERSION }}
6270
channel: stable
6371
cache: true
6472

73+
- name: Set up JDK
74+
if: matrix.language == 'java-kotlin'
75+
uses: actions/setup-java@v5
76+
with:
77+
distribution: temurin
78+
java-version: '17'
79+
6580
- name: Build Windows (C++)
6681
if: matrix.language == 'c-cpp'
6782
run: |
6883
flutter config --enable-windows-desktop
6984
flutter pub get
7085
flutter build windows --debug
7186
87+
- name: Build Android (Kotlin)
88+
if: matrix.language == 'java-kotlin'
89+
run: |
90+
flutter pub get
91+
flutter build apk --debug
92+
7293
- uses: github/codeql-action/analyze@v4
7394
with:
7495
category: "/language:${{ matrix.language }}"

.github/workflows/release.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ permissions:
1616
contents: write
1717

1818
env:
19-
FLUTTER_VERSION: 3.44.4
19+
FLUTTER_VERSION: 3.44.5
2020

2121
jobs:
2222
# Resolve the version string once (tag minus the leading `v`, or the manual input).

pubspec.lock

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -332,10 +332,10 @@ packages:
332332
dependency: transitive
333333
description:
334334
name: gotrue
335-
sha256: ac6b664b35304aece2034c66bc09ce761f9f7c8fb6066bbb6b2932aa87d82653
335+
sha256: "360bba9606e58d5acc59a033ab64ae3cf571a6868f7a7267cb8e9a204b7bf1b2"
336336
url: "https://pub.dev"
337337
source: hosted
338-
version: "2.25.0"
338+
version: "2.26.0"
339339
gtk:
340340
dependency: transitive
341341
description:
@@ -596,10 +596,10 @@ packages:
596596
dependency: transitive
597597
description:
598598
name: passkeys_platform_interface
599-
sha256: "56dd98bbe45d79de87e8683d25741b2f61743542a39a85207b0a5b4bccff600e"
599+
sha256: "9610bd136b3382500390912ddd8517ee99505228b1af7b507b9c907f7e99a47d"
600600
url: "https://pub.dev"
601601
source: hosted
602-
version: "2.7.0"
602+
version: "2.8.0"
603603
path:
604604
dependency: "direct main"
605605
description:
@@ -716,10 +716,10 @@ packages:
716716
dependency: transitive
717717
description:
718718
name: realtime_client
719-
sha256: cf816d406248a6286bf7aa2053b406583ff88bd0842ab7f3f3127d53f6f1c68b
719+
sha256: "0cfbe0047e2591eba348938e9b4e620d5b1a8df6c374757e8eb8645252b8387f"
720720
url: "https://pub.dev"
721721
source: hosted
722-
version: "2.10.0"
722+
version: "2.11.0"
723723
record_use:
724724
dependency: transitive
725725
description:
@@ -921,18 +921,18 @@ packages:
921921
dependency: transitive
922922
description:
923923
name: supabase
924-
sha256: "6933e60614652fa10749eb29fdcc6f2adb6515f5638e5ce28376ae08a626d745"
924+
sha256: "3879996256325fcc9abb03b62b12c07e4eaae2e008e1bf043cc1525184159a43"
925925
url: "https://pub.dev"
926926
source: hosted
927-
version: "2.13.4"
927+
version: "2.14.0"
928928
supabase_flutter:
929929
dependency: "direct main"
930930
description:
931931
name: supabase_flutter
932-
sha256: b6d34558565c14f1b44ff7bc9ca2979ed38ee2907b80ed73e699150cec08b739
932+
sha256: c9916c1cd512ebf3107ec0f83c9dca13d2e1e789629c2a5df896586bff46ce5f
933933
url: "https://pub.dev"
934934
source: hosted
935-
version: "2.15.4"
935+
version: "2.16.0"
936936
synchronized:
937937
dependency: transitive
938938
description:

0 commit comments

Comments
 (0)