Consider applying Isabella's comments in PR 62 (#62) regarding adding more tests for coverage on the new package.
Addressed comments:
tests/repo_exporter/test_base.py:
I think test_identifiers_type_doi is sufficient here since it tests the standard identifiers structure in CITATION.cff. I'd drop test_identifiers_doi unless the shorthand format is intentionally supported.
tests/repo_exporter/test_huggingface.py:
One thing worth confirming separately is the documented License == "N/A" behavior for repos without license metadata, since the test notes that this differs from the legacy exporter. Otherwise, I don't see any blocking issues.
Consider applying Isabella's comments in PR 62 (#62) regarding adding more tests for coverage on the new package.
Addressed comments:
tests/repo_exporter/test_base.py:I think test_identifiers_type_doi is sufficient here since it tests the standard identifiers structure in CITATION.cff. I'd drop test_identifiers_doi unless the shorthand format is intentionally supported.
tests/repo_exporter/test_huggingface.py:One thing worth confirming separately is the documented License == "N/A" behavior for repos without license metadata, since the test notes that this differs from the legacy exporter. Otherwise, I don't see any blocking issues.