Skip to content

Commit 83f70bf

Browse files
committed
refactor(subscriptions): route form to Cloudflare
1 parent 888c159 commit 83f70bf

4 files changed

Lines changed: 17 additions & 24 deletions

File tree

.github/workflows/deploy-cloudflare-frontend.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ concurrency:
1616
cancel-in-progress: true
1717

1818
env:
19-
ALL_UPDATE_SUBSCRIBE: https://doesitarm-functions-scc.vercel.app/api/all-app-updates-subscribe
2019
COMMITS_SOURCE: https://doesitarm-functions-scc.vercel.app/api/commits
2120
GAMES_SOURCE: https://script.google.com/macros/s/AKfycbzGvKKUIaqsMuCj7-A2YRhR-f7GZjl4kSxSN1YyLkS01_CfiyE/exec?id=1er-NivvuIheDmIKBVRu3S_BzA_lZT5z3Z-CxQZ-uPVs&sheet=Games&header=2&startRow=3
2221
HOMEBREW_SOURCE: https://doesitarm-functions-scc.vercel.app/api/homebrew-issue

components/all-updates-subscribe.vue

Lines changed: 16 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
<template>
2-
32
<div>
43
<div
54
v-if="feedbackMessage === null"
@@ -36,13 +35,23 @@
3635
:class="inputClasslist"
3736
:placeholder="isFocused ? 'me@email.com' : placeholder"
3837
:aria-label="placeholder"
38+
autocomplete="email"
3939
name="all-updates-subscribe"
4040
style="width: 240px;"
4141
type="email"
4242
required
4343
@focus="isFocused = true"
4444
@blur="isFocused = false"
4545
>
46+
<input
47+
v-model="website"
48+
aria-hidden="true"
49+
autocomplete="off"
50+
class="hidden"
51+
name="website"
52+
tabindex="-1"
53+
type="text"
54+
>
4655
</div>
4756
</form>
4857
</div>
@@ -54,16 +63,16 @@
5463
{{ feedbackMessage }}
5564
</div>
5665
</div>
57-
5866
</template>
5967

6068
<script>
6169
6270
import { v4 as uuid } from 'uuid'
6371
64-
import { isNuxt } from '~/helpers/environment.js'
6572
import { postJson } from '~/helpers/http.js'
6673
74+
const subscriptionEndpoint = 'https://doesitarm.com/api/subscriptions'
75+
6776
export default {
6877
props: {
6978
// appName: {
@@ -95,6 +104,7 @@ export default {
95104
data: function () {
96105
return {
97106
email: '',
107+
website: '',
98108
99109
isFocused: false,
100110
feedbackMessage: null,
@@ -130,27 +140,13 @@ export default {
130140
131141
methods: {
132142
async trySubmit () {
133-
console.log('Trying submit')
134-
135143
// Set intermediate message
136144
this.feedbackMessage = 'Sending...'
137145
138-
// const pagePath = $nuxt.$route.path
139-
140-
const allUpdateSubscribe = isNuxt( this ) ? this.$config.allUpdateSubscribe : global.$config.allUpdateSubscribe
141-
142-
console.log('allUpdateSubscribe', allUpdateSubscribe)
143-
144-
145-
// https://stackoverflow.com/questions/51995070/post-data-to-a-google-form-with-ajax/55496118#55496118
146-
const actionUrl = allUpdateSubscribe
147-
148-
console.log('actionUrl', actionUrl)
149-
150146
try {
151-
await postJson( actionUrl, {
152-
// Email
153-
'email': this.email
147+
await postJson( subscriptionEndpoint, {
148+
email: this.email,
149+
website: this.website
154150
} )
155151
this.feedbackMessage = 'We\'ll keep you informed!'
156152
} catch ( error ) {

helpers/public-runtime-config.mjs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ function getRuntimeValue ( envValue, fallbackValue = null ) {
1616
}
1717

1818
export const publicRuntimeConfig = {
19-
allUpdateSubscribe: process.env.ALL_UPDATE_SUBSCRIBE,
2019
testResultStore: process.env.TEST_RESULT_STORE,
2120
siteUrl: process.env.URL,
2221
macsVerbiage: getRuntimeValue( process.env.npm_package_config_verbiage_macs, fallbackVerbiage.macs ),

wrangler.jsonc

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,7 @@
3434
"HOMEBREW_SOURCE": "https://doesitarm-functions-scc.vercel.app/api/homebrew-issue",
3535
"COMMITS_SOURCE": "https://doesitarm-functions-scc.vercel.app/api/commits",
3636
"SCANS_SOURCE": "https://doesitarm-functions-scc.vercel.app/app-test-reports.json",
37-
"TEST_RESULT_STORE": "https://doesitarm-functions-scc.vercel.app/api/test-results-store",
38-
"ALL_UPDATE_SUBSCRIBE": "https://doesitarm-functions-scc.vercel.app/api/all-app-updates-subscribe"
37+
"TEST_RESULT_STORE": "https://doesitarm-functions-scc.vercel.app/api/test-results-store"
3938
},
4039

4140
// custom_domain auto-provisions DNS via the Workers subsystem (the deploy

0 commit comments

Comments
 (0)