fix: treat invalid credential expiration as expired (#360)

Author: XargsUK

src/library/__tests__/credentials.test.ts

@@ -44,6 +44,11 @@ describe('credentials', () => {
       const now = new Date();
       expect(areCredentialsExpired(now)).toBe(true);
     });
+
+    it('should return true for an invalid expiration value', () => {
+      expect(areCredentialsExpired('[object Object]')).toBe(true);
+      expect(areCredentialsExpired('')).toBe(true);
+    });
   });
 
   describe('getValidCredentials', () => {

src/library/credentials.ts

@@ -6,7 +6,11 @@ export interface AWSCredentials {
 }
 
 export function areCredentialsExpired(expiration: string | Date): boolean {
-  return new Date(expiration).getTime() <= Date.now();
+  const time = new Date(expiration).getTime();
+  if (isNaN(time)) {
+    return true;
+  }
+  return time <= Date.now();
 }
 
 export async function getValidCredentials(): Promise<AWSCredentials | null> {