Skip to content

Fix tests that rely on behavior of external domains #112

Description

@nharper

Some of the test cases in redirects_test.go and domain_test.go rely on the behavior of external domains. For some of these tests, that behavior has changed and the tests are no longer passing.

Preferably, the tests would be hermetic and not connect to any external sites. If that's not possible, I'd prefer restricting it to domains where we have some reasonable assurance that it will keep behaving the way we expect for a test (e.g. badssl.com).

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions