Implement platform support for max params and insert syntax

Author: BackEndTea

src/Connection.php

@@ -535,11 +535,20 @@ public function insert(string $table, array $data, array $types = []): int|strin
      */
     public function insertMany(string $table, array $rows, array $types = []): int|string
     {
+        $platform = $this->getDatabasePlatform();
+
+        if (! $platform->supportsBulkInserts($this)) {
+            // TODO: custom exception
+            throw new Exception('Bulk insert operation not supported by this platform');
+        }
+
         $numRows = count($rows);
         if ($numRows === 0) {
             return 0;
         }
 
+        $maxBoundParams = $platform->getMaximumAmountOfBoundParameters($this);
+
         $columns = [];
         $values  = [];
         $set     = [];
@@ -551,7 +560,13 @@ public function insertMany(string $table, array $rows, array $types = []): int|s
                 $first       = false;
                 $columns     = array_keys($row);
                 $columnCount = count($columns);
-                $set         = array_fill(0, count($columns), '?');
+
+                if ($columnCount * $numRows > $maxBoundParams) {
+                    // TODO: add a custom exception
+                    throw new Exception('Too many bound params');
+                }
+
+                $set = array_fill(0, count($columns), '?');
             }
 
             if ($columnCount !== count($row)) {

src/Driver/AbstractOracleDriver.php

@@ -8,16 +8,23 @@
 use Doctrine\DBAL\Driver\AbstractOracleDriver\EasyConnectString;
 use Doctrine\DBAL\Driver\API\ExceptionConverter as ExceptionConverterInterface;
 use Doctrine\DBAL\Driver\API\OCI\ExceptionConverter;
+use Doctrine\DBAL\Platforms\Oracle23Platform;
 use Doctrine\DBAL\Platforms\OraclePlatform;
 use Doctrine\DBAL\ServerVersionProvider;
 
+use function version_compare;
+
 /**
  * Abstract base implementation of the {@see Driver} interface for Oracle based drivers.
  */
 abstract class AbstractOracleDriver implements Driver
 {
     public function getDatabasePlatform(ServerVersionProvider $versionProvider): OraclePlatform
     {
+        if (version_compare($versionProvider->getServerVersion(), '23.0.0', '>=')) {
+            return new Oracle23Platform();
+        }
+
         return new OraclePlatform();
     }
 

src/Platforms/AbstractMySQLPlatform.php

@@ -929,4 +929,13 @@ public function createSQLParser(): Parser
     {
         return new Parser(true);
     }
+
+    /**
+     * Sources: https://dev.mysql.com/worklog/task/?id=1803
+     * https://stackoverflow.com/a/6582902
+     */
+    public function getMaximumAmountOfBoundParameters(Connection $connection): int
+    {
+        return 65535;
+    }
 }

src/Platforms/AbstractPlatform.php

@@ -2482,4 +2482,15 @@ public function createMetadataProvider(Connection $connection): MetadataProvider
      * database schema according to the dialect of the platform.
      */
     abstract public function createSchemaManager(Connection $connection): AbstractSchemaManager;
+
+    /** @throws Exception */
+    public function getMaximumAmountOfBoundParameters(Connection $connection): int
+    {
+        throw NotSupported::new(__METHOD__);
+    }
+
+    public function supportsBulkInserts(): bool
+    {
+        return true;
+    }
 }

src/Platforms/DB2Platform.php

@@ -597,4 +597,12 @@ public function createSchemaManager(Connection $connection): DB2SchemaManager
     {
         return new DB2SchemaManager($connection, $this);
     }
+
+    /**
+     * Source: https://www.bmc.com/blogs/db2-limits/
+     */
+    public function getMaximumAmountOfBoundParameters(Connection $connection): int
+    {
+        return 16000;
+    }
 }

src/Platforms/Oracle23Platform.php

@@ -0,0 +1,15 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Doctrine\DBAL\Platforms;
+
+use Doctrine\DBAL\Connection;
+
+class Oracle23Platform extends OraclePlatform
+{
+    public function supportsBulkInserts(): bool
+    {
+        return true;
+    }
+}

src/Platforms/OraclePlatform.php

@@ -858,4 +858,17 @@ public function createSchemaManager(Connection $connection): OracleSchemaManager
     {
         return new OracleSchemaManager($connection, $this);
     }
+
+    /**
+     * https://docs.oracle.com/cd/B10501_01/appdev.920/a96624/e_limits.htm#LNPLS018
+     */
+    public function getMaximumAmountOfBoundParameters(Connection $connection): int
+    {
+        return 64000;
+    }
+
+    public function supportsBulkInserts(): bool
+    {
+        return false;
+    }
 }

src/Platforms/PostgreSQLPlatform.php

@@ -843,4 +843,9 @@ public function createSchemaManager(Connection $connection): PostgreSQLSchemaMan
     {
         return new PostgreSQLSchemaManager($connection, $this);
     }
+
+    public function getMaximumAmountOfBoundParameters(Connection $connection): int
+    {
+        return 34464;
+    }
 }

src/Platforms/SQLServerPlatform.php

@@ -1334,4 +1334,12 @@ public function createSchemaManager(Connection $connection): SQLServerSchemaMana
     {
         return new SQLServerSchemaManager($connection, $this);
     }
+
+    /**
+     * Source: https://learn.microsoft.com/en-us/sql/sql-server/maximum-capacity-specifications-for-sql-server?view=sql-server-ver17
+     */
+    public function getMaximumAmountOfBoundParameters(Connection $connection): int
+    {
+        return 2100;
+    }
 }

src/Platforms/SQLitePlatform.php

@@ -976,4 +976,16 @@ public function getUnionSelectPartSQL(string $subQuery): string
     {
         return $subQuery;
     }
+
+    /**
+     * @see https://www.sqlite.org/limits.html Secition 9:
+     * To prevent excessive memory allocations, the maximum value of a host parameter number is SQLITE_MAX_VARIABLE_NUMBER,
+     * which defaults to 999 for SQLite versions prior to 3.32.0 (2020-05-22) or 32766 for SQLite versions after 3.32.0.
+     *
+     * TODO: Should we create a new SQLite platform version which returns `32766` for post 3.32.0?, or read the SQLITE_MAX_VARIABLE_NUMBER?
+     */
+    public function getMaximumAmountOfBoundParameters(Connection $connection): int
+    {
+        return 999;
+    }
 }