fix(automation): page workflow list to exhaustion, not a fixed page cap

_list_all_workflows now loops until a short/empty page or total_count is
reached, instead of stopping at page 10. Added tests for pagination past ten
pages and for stopping at total_count without an extra request.

Author: nazarli-shabnam

apps/api/src/routers/automation.py

@@ -164,16 +164,21 @@ def _list_all_workflows(client: GitHubClient, owner: str, repo: str) -> list[dic
     ``{total_count, workflows}`` object (not a bare array), so request_paginated's
     Link-following can't be reused -- page through it explicitly instead."""
     workflows: list[dict] = []
-    for page in range(1, 11):  # hard stop at 1000 workflows -- far past any real repo
+    page = 1
+    while True:
         data = client.request(
             "GET",
             f"/repos/{owner}/{repo}/actions/workflows",
             params={"per_page": 100, "page": page},
         )
         batch = data.get("workflows", [])
         workflows.extend(batch)
-        if len(batch) < 100:
+        total = data.get("total_count")
+        # Stop on an empty page (guards against a misbehaving API and infinite loops),
+        # a short page, or once total_count says we've seen everything.
+        if not batch or len(batch) < 100 or (total is not None and len(workflows) >= total):
             break
+        page += 1
     return workflows
 
 

apps/api/tests/test_automation.py

@@ -545,6 +545,54 @@ def test_personal_dispatch_all_paginates_past_first_page(automation_client, db):
     assert {log.target for log in logs} == {"acme/demo#100", "acme/demo#101"}
 
 
+def test_personal_dispatch_all_paginates_beyond_ten_pages(automation_client, db):
+    # 11 pages of 100 inactive workflows, then a final short page holding the only
+    # two active ones -- the loop must not stop early at an arbitrary page cap.
+    db.add(User(id=_USER.id, email=_USER.email, name=None, password_hash=None, is_workspace_admin=False))
+    db.commit()
+    full_page = {
+        "total_count": 1102,
+        "workflows": [{"id": i, "name": f"w{i}", "path": "p", "state": "disabled_manually"} for i in range(100)],
+    }
+    last_page = {
+        "total_count": 1102,
+        "workflows": [
+            {"id": 1100, "name": "CI", "path": "p", "state": "active"},
+            {"id": 1101, "name": "Release", "path": "p", "state": "active"},
+        ],
+    }
+    with patch("src.routers.automation.GitHubClient") as mock_client:
+        mock_client.return_value.request.side_effect = [full_page] * 11 + [last_page, {}, {}]
+        resp = automation_client.post(
+            "/me/repos/acme/demo/workflows/dispatch-all",
+            json={"token": "ghp_testtoken123456789012345678901234", "ref": "main"},
+        )
+    assert resp.status_code == 200
+    assert resp.json()["dispatched_count"] == 2
+
+
+def test_personal_dispatch_all_stops_at_total_count(automation_client, db):
+    # A page that is exactly per_page long but total_count says it's the last:
+    # the loop must not fetch another (non-existent) page.
+    db.add(User(id=_USER.id, email=_USER.email, name=None, password_hash=None, is_workspace_admin=False))
+    db.commit()
+    only_page = {
+        "total_count": 100,
+        "workflows": [{"id": i, "name": f"w{i}", "path": "p", "state": "disabled_manually"} for i in range(100)],
+    }
+    with patch("src.routers.automation.GitHubClient") as mock_client:
+        mock_client.return_value.request.side_effect = [only_page]  # exactly one GET, no POSTs
+        resp = automation_client.post(
+            "/me/repos/acme/demo/workflows/dispatch-all",
+            json={"token": "ghp_testtoken123456789012345678901234", "ref": "main"},
+        )
+    assert resp.status_code == 200
+    assert resp.json() == {
+        "ref": "main", "results": [], "dispatched_count": 0, "skipped_count": 0, "failed_count": 0,
+    }
+    assert mock_client.return_value.request.call_count == 1
+
+
 def test_org_dispatch_all_no_token_returns_400(db, acme_org):
     client = _org_client(db, acme_org["admin"].id, email=acme_org["admin"].email)
     resp = client.post("/orgs/acme/repos/acme/demo/workflows/dispatch-all", json={"ref": "main"})