test: full ViewModel coverage, flow cancellation fixes, no-SIM state, lint cleanup (#37)

Tests (313 -> 363, all 30 features covered)
- DashboardViewModel: hardware list, last-used persistence, recent-alert cap
- WiFi, BLE, GPS, cell tower, tracker, rogue AP, deauth and signal logger
  ViewModels: start/stop, auto-stop timers, error surfacing, alert-center
  forwarding, dedup and reset paths
- CellTowerAnalyzer: SIM-absent and empty states
- core/testing/MainDispatcherRule for viewModelScope tests

Production fixes the tests and lint surfaced
- CellTowerAnalyzer and UltrasonicAnalyzer caught the collector's
  cancellation inside their flow builders and emitted into a cancelled
  flow ("flow exception transparency violated"). State is now built inside
  the try and emitted outside it; cancellation is rethrown.
- Cell Tower screen explains when no serving cell can appear: new
  CellTowerState.simAbsent (from TelephonyManager.simState) drives a
  "No SIM card detected" card instead of an unexplained empty area.
- DeviceInfo is built via DeviceInfo.fromBuild() (null-safe) and provided
  by Hilt, so DashboardViewModel no longer reads android.os.Build in a
  constructor default that is null on the JVM.
- Signal Logger no longer counts every device in the first scan as "new".

Lint 149 -> 20 warnings
- String.format now passes Locale.US (28 sites)
- Dropped empty super.onCleared() calls (24 ViewModels)
- CellInfo.UNAVAILABLE inlined as a local constant for minSdk 26
- KTX: SharedPreferences.edit {}, createBitmap, Bitmap.set, toColorInt,
  mutableIntStateOf
- Modifier is the first optional parameter on three composables
- Removed unused strings, colours and the unused ic_splash / mipmap
  ic_notification bitmaps; mipmap-anydpi-v26 merged into mipmap-anydpi
- Removed the obsolete SDK 26 check, the redundant activity label and the
  hardcoded /sdcard path
Remaining warnings are dependency version nudges, the branding vector
size, resource shrinking and identical round/regular launcher bitmaps.

Verified on Vivo V2036 (Android 13): splash, launcher icon, cell tower
no-SIM card, ultrasonic start/stop with no flow violations or crashes.

Claude-Session: https://claude.ai/code/session_011kW3RTWkhP74LwWy1UFbwt

Author: theabhishekchandra

app/src/main/AndroidManifest.xml

@@ -109,7 +109,6 @@
             android:name=".MainActivity"
             android:exported="true"
             android:launchMode="singleTask"
-            android:label="@string/app_name"
             android:theme="@style/Theme.ZeroDroid.Splash">
             <intent-filter>
                 <action android:name="android.intent.action.MAIN" />

app/src/main/java/com/abhishek/zerodroid/core/di/HardwareModule.kt

@@ -2,6 +2,7 @@ package com.abhishek.zerodroid.core.di
 
 import android.content.Context
 import com.abhishek.zerodroid.core.hardware.HardwareChecker
+import com.abhishek.zerodroid.features.dashboard.DeviceInfo
 import dagger.Module
 import dagger.Provides
 import dagger.hilt.InstallIn
@@ -17,4 +18,8 @@ object HardwareModule {
     @Singleton
     fun provideHardwareChecker(@ApplicationContext context: Context): HardwareChecker =
         HardwareChecker(context)
+
+    @Provides
+    @Singleton
+    fun provideDeviceInfo(): DeviceInfo = DeviceInfo.fromBuild()
 }

app/src/main/java/com/abhishek/zerodroid/core/di/SystemServiceModule.kt

@@ -8,7 +8,6 @@ import android.hardware.usb.UsbManager
 import android.net.wifi.WifiManager
 import android.net.wifi.aware.WifiAwareManager
 import android.nfc.NfcAdapter
-import android.os.Build
 import android.telephony.TelephonyManager
 import dagger.Module
 import dagger.Provides
@@ -59,7 +58,5 @@ object SystemServiceModule {
     @Provides
     @Singleton
     fun provideWifiAwareManager(@ApplicationContext context: Context): WifiAwareManager? =
-        if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.O) {
-            context.getSystemService(Context.WIFI_AWARE_SERVICE) as? WifiAwareManager
-        } else null
+        context.getSystemService(Context.WIFI_AWARE_SERVICE) as? WifiAwareManager
 }

app/src/main/java/com/abhishek/zerodroid/core/ui/EthicalUseDialog.kt

@@ -13,6 +13,7 @@ import androidx.compose.runtime.setValue
 import androidx.compose.ui.platform.LocalContext
 import androidx.compose.ui.res.stringResource
 import com.abhishek.zerodroid.R
+import androidx.core.content.edit
 
 private const val PREFS_NAME = "zerodroid_prefs"
 private const val KEY_ETHICAL_ACCEPTED = "ethical_use_accepted"
@@ -41,7 +42,7 @@ fun EthicalUseDialog() {
             },
             confirmButton = {
                 TextButton(onClick = {
-                    prefs.edit().putBoolean(KEY_ETHICAL_ACCEPTED, true).apply()
+                    prefs.edit { putBoolean(KEY_ETHICAL_ACCEPTED, true) }
                     accepted = true
                 }) {
                     Text(

app/src/main/java/com/abhishek/zerodroid/features/ble/domain/BleDistanceEstimator.kt

@@ -1,6 +1,7 @@
 package com.abhishek.zerodroid.features.ble.domain
 
 import kotlin.math.pow
+import java.util.Locale
 
 object BleDistanceEstimator {
     private const val DEFAULT_TX_POWER = -59
@@ -15,9 +16,9 @@ object BleDistanceEstimator {
     fun getDistanceLabel(distanceM: Double): String = when {
         distanceM < 0 -> "Unknown"
         distanceM < 0.5 -> "Immediate"
-        distanceM < 2.0 -> "Near (${String.format("%.1f", distanceM)}m)"
-        distanceM < 10.0 -> "Medium (${String.format("%.1f", distanceM)}m)"
-        else -> "Far (${String.format("%.0f", distanceM)}m)"
+        distanceM < 2.0 -> "Near (${String.format(Locale.US, "%.1f", distanceM)}m)"
+        distanceM < 10.0 -> "Medium (${String.format(Locale.US, "%.1f", distanceM)}m)"
+        else -> "Far (${String.format(Locale.US, "%.0f", distanceM)}m)"
     }
 
     fun getProximityLabel(distanceM: Double): String = when {

app/src/main/java/com/abhishek/zerodroid/features/ble/ui/HciSnoopScreen.kt

@@ -57,6 +57,7 @@ import com.abhishek.zerodroid.ui.theme.TerminalAmber
 import com.abhishek.zerodroid.ui.theme.TerminalCyan
 import com.abhishek.zerodroid.ui.theme.TerminalGreen
 import com.abhishek.zerodroid.ui.theme.TerminalRed
+import java.util.Locale
 
 @Composable
 fun HciSnoopPanel(viewModel: HciSnoopViewModel) {
@@ -238,7 +239,7 @@ private fun LogInfoCard(log: HciSnoopLog, loadedFrom: String?) {
                 log.fileSize < 0 -> "unknown"
                 log.fileSize < 1024 -> "${log.fileSize} B"
                 log.fileSize < 1024 * 1024 -> "${log.fileSize / 1024} KB"
-                else -> String.format("%.1f MB", log.fileSize / (1024.0 * 1024.0))
+                else -> String.format(Locale.US, "%.1f MB", log.fileSize / (1024.0 * 1024.0))
             }
 
             val cmdCount = log.packets.count { it.packetType == HciPacketType.Command }
@@ -340,7 +341,7 @@ private fun PacketCard(packet: HciPacket) {
     val hours = (totalSeconds / 3600) % 24
     val minutes = (totalSeconds % 3600) / 60
     val seconds = totalSeconds % 60
-    val timeStr = String.format("%02d:%02d:%02d.%03d", hours, minutes, seconds, millis)
+    val timeStr = String.format(Locale.US, "%02d:%02d:%02d.%03d", hours, minutes, seconds, millis)
 
     TerminalCard {
         Column(

app/src/main/java/com/abhishek/zerodroid/features/ble/viewmodel/BleViewModel.kt

@@ -93,7 +93,6 @@ class BleViewModel @Inject constructor(
     }
 
     override fun onCleared() {
-        super.onCleared()
         stopScan()
     }
 

app/src/main/java/com/abhishek/zerodroid/features/ble/viewmodel/GattViewModel.kt

@@ -193,7 +193,6 @@ class GattViewModel @Inject constructor(
     }
 
     override fun onCleared() {
-        super.onCleared()
         explorer.close()
     }
 

app/src/main/java/com/abhishek/zerodroid/features/ble/viewmodel/HciSnoopViewModel.kt

@@ -40,7 +40,6 @@ class HciSnoopViewModel @Inject constructor(
     companion object {
         private val KNOWN_LOG_PATHS = listOf(
             "/data/misc/bluetooth/logs/btsnoop_hci.log",
-            "/sdcard/btsnoop_hci.log",
             "/data/log/bt/btsnoop_hci.log",
             "/storage/emulated/0/btsnoop_hci.log"
         )

app/src/main/java/com/abhishek/zerodroid/features/bluetooth_classic/ui/SdpServicePanel.kt

@@ -60,10 +60,10 @@ fun SdpServicePanel(
     deviceName: String?,
     services: List<SdpServiceInfo>,
     isQuerying: Boolean,
-    isCached: Boolean = false,
     onQuerySdp: () -> Unit,
     onDismiss: () -> Unit,
-    modifier: Modifier = Modifier
+    modifier: Modifier = Modifier,
+    isCached: Boolean = false
 ) {
     TerminalCard(modifier = modifier.fillMaxWidth()) {
         Column(