SCB_DisableDCache: Always use __ALIGNED attribute for struct locals when using gcc/clang - #311
Merged
JonatanAntoni merged 3 commits intoSep 1, 2026
Conversation
Contributor
|
Maybe @JonatanAntoni you could have a look here, since you also reviewed #288. |
minyuan-xue
reviewed
Sep 1, 2026
minyuan-xue
suggested changes
Sep 1, 2026
minyuan-xue
left a comment
There was a problem hiding this comment.
I also encountered this problem when using -Og. This solution is necessary, but the parentheses here are not matched. Hope this PR can be merged soon.
Test Results 256 files - 388 256 suites - 388 0s ⏱️ - 11m 55s Results for commit e01645a. ± Comparison against base commit 0be833b. This pull request removes 49 and adds 56 tests. Note that renamed tests count towards both.This pull request removes 5 skipped tests and adds 2 skipped tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
Co-authored-by: minyuan_xue <minyuan_xue@realsil.com.cn>
JonatanAntoni
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Struct
localswas only aligned to the D-cache line size when__OPTIMIZE__was not defined. This led to intermittent failures (endless loop) of MIMXRT1166.This removes the
!defined(__OPTIMIZE__)condition so the struct is always aligned when building with gcc or clang, for every optimization level.Related to #286