-
Notifications
You must be signed in to change notification settings - Fork 75
Progress ring and Spinner Use cases #1371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jamesnw
wants to merge
16
commits into
main
Choose a base branch
from
progress-ring-use-case
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 8 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
3938068
Add spinner guide
jamesnw a1bbbcb
Merge branch 'main' of https://github.com/GoogleChrome/modern-web-gui…
jamesnw 4446b4b
Revisions
jamesnw 9395a62
Preflight
jamesnw 54a5a88
Specificity and overrides dance
jamesnw fc57a25
Merge branch 'main' of https://github.com/GoogleChrome/modern-web-gui…
jamesnw 590ba37
Spinner updates
jamesnw 2c03aca
Update progress ring, expectations
jamesnw 3121d99
Revisions
jamesnw efd214c
Apply batched suggestions from code review
jamesnw bfed999
Revisions
jamesnw 1a24d53
preflight
jamesnw d0e9048
Readd animations
jamesnw 5ea94a4
Merge branch 'main' of https://github.com/GoogleChrome/modern-web-gui…
jamesnw 6b94b7c
Address auto-lint review
jamesnw bb1448c
Apply batched suggestions from code review
jamesnw File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| # Expectations | ||
|
|
||
| - The component contains a native HTML `<progress>` element. | ||
| - The component is visible on the page. | ||
| - The visual progress ring is implemented using a CSS `conic-gradient`. | ||
| - The center of the progress ring is transparent or "hollowed out" using `background-clip: border-area`. | ||
| - If `background-clip: border-area` is not supported, fall back to hollowing out the center of the ring with a radial gradient mask. | ||
| - The `value` attribute on `<progress>` is used to drive the visual progress of the ring using `attr()`. | ||
| - If using `attr()` on non-content properties is not supported, fallback to update the visual ring with JavaScript via the `--value` property. | ||
| - The component supports displaying text content (e.g., the percentage) in the center of the ring. | ||
| - The ring smoothly transitions between values when the `--value` property is updated (requiring `@property` support in the browser). | ||
| - The `<progress>` element includes an `aria-label` for accessibility. | ||
| - The component's fill color changes to a success color (e.g., green) when the progress value reaches 100%. | ||
| - The component has a distinct visual "track" (background) behind the progress fill. | ||
| - The spinner respects `prefers-reduced-motion` by changing to a new value immediately, rather than having a smooth transition. | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.