Curly Vector 1 implementatioin - #610
Draft
jukent wants to merge 7 commits into
Draft
Conversation
jukent
marked this pull request as ready for review
August 7, 2024 22:27
kafitzgerald
reviewed
Aug 9, 2024
kafitzgerald
left a comment
Contributor
There was a problem hiding this comment.
This is really cool!
It looks like the length scales of the vectors don't match the originals though: https://www.ncl.ucar.edu/Applications/Images/vector_1_lg.png
I think this is because of more conceptual differences between streamplot (integrates forward or backward until some constraint) and curly vectors (length varies with vector magnitude). It's handled length normalization in the various approaches here, but I don't know how robust that is.
kafitzgerald
marked this pull request as draft
October 21, 2024 16:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This method of making curly vectors uses streamlines without arrows, finds their end points, and afixes length-0 quiver arrows to the ends. We may want to investigate a curly vector function in geocat-viz, but this demonstrates the recommended work around by matplotlib and will be useful to users for now.