fix: keep context menu inside viewport near bottom/right edge (#310) - #478
Open
Radexito wants to merge 1 commit into
Open
fix: keep context menu inside viewport near bottom/right edge (#310)#478Radexito wants to merge 1 commit into
Radexito wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #310
Problem
Right-clicking a row near the bottom/right edge of the window rendered the context menu partially or fully off-screen — the position was clamped, but the menu's own height/width was never accounted for.
Fix
After the menu renders, measure it (
getBoundingClientRect) and nudge it up/left by exactly the viewport overflow (8px margin), so it always stays inside the window. Applies to both context menus:MusicLibrary.jsx(track menu; re-measures on drill/submenu content change)FileExplorerView.jsx(explorer menu)The existing
flipLeft/flipUpsubmenu direction logic is untouched.Test
npm run lint(renderer): 0 errors.