fix(3387): Pass channel ID to name mappings to mobile, use channel names in notifications - #3396
Merged
Merged
Conversation
islathehut
marked this pull request as ready for review
July 30, 2026 13:26
islathehut
changed the title
islathehut
changed the title
adrastaea
requested changes
Aug 3, 2026
| channelId | ||
| } else { | ||
| channelId.substringBefore('_') | ||
| var channelName = jsonMessage.get("channelName") as? String? |
Collaborator
There was a problem hiding this comment.
Suggested change
| var channelName = jsonMessage.get("channelName") as? String? | |
| val channelName = jsonMessage.optString("channelName", channelId) |
Use optstring because passing null to JSONObject.put() in QssFirebaseMessagingService omits the property causing jsonMessage.get("channelName") to throw.
|
|
||
| static func addChannelMetadata(teamId: String, channelId: String, channelName: String) throws { | ||
| let keyName = KeychainService.generateChannelMetadataKeyName(teamId: teamId, channelId: channelId) | ||
| try upsertString(account: keyName, value: channelName, service: lfaKeyService) |
Collaborator
There was a problem hiding this comment.
We also need to add try deleteAll(matchingPrefix: channelMetadataKeyPrefix, service: lfaKeyService) to clearAllQuietData to clean these up when leaving community
adrastaea
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
(Optional) Mobile checklist
Please ensure you completed the following checks if you did any changes to the mobile package: