fix(3393): Ensure channel deletions are honored

[islathehut]

Pull Request Checklist

• I have linked this PR to a related GitHub issue.
• I have added a description of the change (and Github issue number, if any) to the root CHANGELOG.md.

(Optional) Mobile checklist

Please ensure you completed the following checks if you did any changes to the mobile package:

• I have run e2e tests for mobile
• I have updated base screenshots for visual regression tests

[islathehut]

This is the fix. Basically when the deletions were processed we would skip over marking the put hashes as indexed and that resulted in future reindexing treating them as fresh puts since the check for an entry being indexed is based on the hash.

[adrastaea]

I think there may be an issue with this though that will cause PUT("key", "old value") -> DEL ("key") -> PUT("key", "new value") to result in the key to still be indexed as deleted because we are storing the deletion of key persistently and skipping processing the new PUT because it was previously deleted. You can add

  it('allows a newer PUT to recreate a deleted key', async () => {
    orbitDbService = await module.resolve(OrbitDbService)
    await orbitDbService.create(ipfsService.ipfsInstance!)

    const store = await orbitDbService.open<KeyValueIndexedValidatedType<string>>(
      `recreated-key-test-store-${Date.now()}`,
      {
        Database: KeyValueIndexedValidated(),
        AccessController: IPFSAccessController({ write: ['*'] }),
        sync: false,
      }
    )

    await store.put('key', 'old value')
    await store.del('key')
    await store.put('key', 'new value')

    await expect(store.get('key')).resolves.toBe('new value')
  })

to the orbitdb service tests to prove this.

[adrastaea]

I think there may be an issue with this though that will cause PUT("key", "old value") -> DEL ("key") -> PUT("key", "new value") to result in the key to still be indexed as deleted because we are storing the deletion of key persistently and skipping processing the new PUT because it was previously deleted. You can add

  it('allows a newer PUT to recreate a deleted key', async () => {
    orbitDbService = await module.resolve(OrbitDbService)
    await orbitDbService.create(ipfsService.ipfsInstance!)

    const store = await orbitDbService.open<KeyValueIndexedValidatedType<string>>(
      `recreated-key-test-store-${Date.now()}`,
      {
        Database: KeyValueIndexedValidated(),
        AccessController: IPFSAccessController({ write: ['*'] }),
        sync: false,
      }
    )

    await store.put('key', 'old value')
    await store.del('key')
    await store.put('key', 'new value')

    await expect(store.get('key')).resolves.toBe('new value')
  })

to the orbitdb service tests to prove this.