You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@pitrou I'm very much on board with the sparse tensors. I so wonder about tensors, are we sure this is not being used? I'm ok to add a deprecation and wait for a release to see if we hear back. But my expectation is there would be some users out there.
I'm ok to add a deprecation and wait for a release to see if we hear back. But my expectation is there would be some users out there.
Hopefully the deprecation will have them chime in? But my attempt at code-searching this on GH did not lead to many recent relevant results.
Agreed. I'll take a look myself and report back.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Deprecate IPC APIs for reading and writing Tensor / SparseTensor messages.
Deprecating IPC support for Tensor and SparseTensor was discussed in https://lists.apache.org/thread/z2kl4g1353mbtgpt3qo7j3bzohq0q7fv.
Are these changes tested?
By existing CI tests.
Are there any user-facing changes?
No.