Skip to content

GH-51101: [C++][Emscripten] Increase test stack size - #51103

Merged
kou merged 1 commit into
apache:mainfrom
rok:emscripten-integration-test-fix
Aug 31, 2026
Merged

GH-51101: [C++][Emscripten] Increase test stack size#51103
kou merged 1 commit into
apache:mainfrom
rok:emscripten-integration-test-fix

Conversation

@rok

@rok rok commented Aug 31, 2026 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

Rationale for this change

JSON integration tests fail on deeply nested lists we want to fix that.

What changes are included in this PR?

We give Emscripten test executable a bigger stack size (1 MiB) and hope it's enough.

Are these changes tested?

By CI.

Are there any user-facing changes?

No, integration testing only change.

Copilot AI lite review requested due to automatic review settings August 31, 2026 15:44
@github-actions github-actions Bot added the awaiting committer review Awaiting committer review label Aug 31, 2026
@github-actions

github-actions Bot commented Aug 31, 2026

Copy link
Copy Markdown

⚠️ GitHub issue #51101 has been automatically assigned in GitHub to PR creator.

@rok

rok commented Aug 31, 2026

Copy link
Copy Markdown
Member Author

@github-actions crossbow submit test-ubuntu-22.04-cpp-emscripten

Copilot AI reviewed Aug 31, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts the C++ Emscripten test build/link flags to mitigate JSON integration test failures on deeply nested lists (GH-51101) by increasing the WebAssembly stack size for test executables run under Node.

Changes:

  • Add an explicit Emscripten -sSTACK_SIZE=1048576 linker setting for Emscripten test executables (both Release and non-Release).

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread cpp/cmake_modules/SetupCxxFlags.cmake Outdated
@github-actions

github-actions Bot commented Aug 31, 2026

Copy link
Copy Markdown

Revision: ef53551

Submitted crossbow builds: ursacomputing/crossbow @ actions-32d7a5c397

Task Status
test-ubuntu-22.04-cpp-emscripten GitHub Actions

Copilot AI review requested due to automatic review settings August 31, 2026 16:12
@rok
rok force-pushed the emscripten-integration-test-fix branch from ef53551 to 5196918 Compare August 31, 2026 16:12
@rok

rok commented Aug 31, 2026

Copy link
Copy Markdown
Member Author

@pitrou it appears to be the stack size.

@rok

rok commented Aug 31, 2026

Copy link
Copy Markdown
Member Author

@github-actions crossbow submit test-ubuntu-22.04-cpp-emscripten

@github-actions github-actions Bot added awaiting changes Awaiting changes and removed awaiting committer review Awaiting committer review labels Aug 31, 2026
@rok rok mentioned this pull request Aug 31, 2026
Closed
Copilot AI reviewed Aug 31, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

@github-actions

github-actions Bot commented Aug 31, 2026

Copy link
Copy Markdown

Revision: 5196918

Submitted crossbow builds: ursacomputing/crossbow @ actions-0dc746c524

Task Status
test-ubuntu-22.04-cpp-emscripten GitHub Actions

@pitrou

pitrou commented Aug 31, 2026

Copy link
Copy Markdown
Member

@pitrou it appears to be the stack size.

The error message was quite explicit about it. 🙃

@rok

rok commented Aug 31, 2026

Copy link
Copy Markdown
Member Author

@pitrou well, if CI passes I suggest we merge :).

@rok
rok requested review from pitrou and a balanced review from Copilot August 31, 2026 16:46
@pitrou

pitrou commented Aug 31, 2026

Copy link
Copy Markdown
Member

Well, definitely!

Copilot AI reviewed Aug 31, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

kou
kou approved these changes Aug 31, 2026
View reviewed changes

@kou kou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou
kou merged commit 3fcc1c0 into apache:main Aug 31, 2026
59 of 60 checks passed
@kou kou removed the awaiting changes Awaiting changes label Aug 31, 2026
@github-actions github-actions Bot added the awaiting merge Awaiting merge label Aug 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@kou kou kou approved these changes
@pitrou pitrou pitrou approved these changes

Assignees

No one assigned

Labels

awaiting merge Awaiting merge Component: C++

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rok @pitrou @kou