GH-51096: [CI][C++] Remove useless test-file-cleanup and retry logic from run-test.sh - #51110
Open
Diveyam-Mishra wants to merge 1 commit into
Open
GH-51096: [CI][C++] Remove useless test-file-cleanup and retry logic from run-test.sh#51110Diveyam-Mishra wants to merge 1 commit into
Diveyam-Mishra wants to merge 1 commit into
Conversation
…logic from run-test.sh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
As noted in GH-51096, the test-file-cleanup code in run-test.sh calls find twice back-to-back with the same parameters, computes the difference, and tries to delete files only in the second result. But nothing happens between the two find calls, so the results are always identical and no files are ever deleted. Additionally, $TEST_TMPDIR was never defined anywhere in the codebase.
What changes are included in this PR?
Removed the TEST_EXECUTION_ATTEMPTS variable.
Removed the entire retry for loop and TEST_TMPDIR cleanup logic (the two find calls, comm diff, and directory deletion).
Are these changes tested?
Yes.
Are there any user-facing changes?
No.