fix: IOutput.Write(...) overloads now have argument IFormattingInfo set - #502
Merged
Conversation
axunonb
force-pushed
the
pr/output-write
branch
from
October 11, 2025 15:00
c97e833 to
23f07f7
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #502 +/- ##
===================================
- Coverage 97% 97% -0%
===================================
Files 99 99
Lines 3426 3424 -2
===================================
- Hits 3321 3319 -2
Misses 105 105 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
axunonb
force-pushed
the
pr/output-write
branch
from
October 12, 2025 07:43
23f07f7 to
b819315
Compare
…te(ReadOnlySpan<char>, IFormattingInfo)`
karljj1
previously approved these changes
Oct 13, 2025
| /// </summary> | ||
| /// <param name="text"></param> | ||
| /// <param name="formattingInfo"></param> | ||
| // vNext: Remove formattingInfo argument? Or make it non-optional and non-nullable? |
Member
Author
There was a problem hiding this comment.
Next major version (v4) - what do you think?
| using System.IO; | ||
| using SmartFormat.Core.Extensions; | ||
| using SmartFormat.ZString; | ||
| using static System.Net.Mime.MediaTypeNames; |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RTFOutputfromDemogives example how usefulIFormattingInfoas argument can be.Resolves #501