Refactor SplitList - #509
Merged
Merged
Conversation
Class `Format`: * Explicitly limit the max. number of splits to `int.MaxValue` * `Format.Split(...)` now creates the `SplitList` cache, instead of the `SplitList` indexer Class `SplitList`: * Added new method `CreateSplitCache()` * `SplitList` indexer throws if `SplitList` cache is not filled Enhance unit test coverage for `SplitList`
|
axunonb
marked this pull request as ready for review
November 2, 2025 21:34
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #509 +/- ##
===================================
Coverage 97% 97%
===================================
Files 99 99
Lines 3424 3431 +7
===================================
+ Hits 3319 3339 +20
+ Misses 105 92 -13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Class
Format:int.MaxValue(had this limit implicitly before)Format.Split(...)now creates theSplitListcache, instead of theSplitListindexerClass
SplitList:CreateSplitCache()SplitListindexer throws ifSplitListcache is not filledIEnumerator<Format> GetEnumerator()andIEnumerator IEnumerable.GetEnumerator()Enhance unit test coverage for
SplitList