fix(renderer): flush queued view before insert above - #1741
Open
yanmxa wants to merge 1 commit into
Open
Conversation
Signed-off-by: Meng Yan <yanmxa@gmail.com>
yanmxa
marked this pull request as ready for review
July 23, 2026 15:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ViewbeforeinsertAbovecalculates scroll geometryRoot cause
renderonly queues the latestView; the frame ticker flushes it asynchronously.Printlncan therefore reachinsertAboveafter the model has produced a shorter view but before that view has reached the terminal.At that point,
insertAboveuses the previouscellbufand cursor geometry. Rows from the stale managed frame can then be moved into native scrollback and remain there permanently.Flushing at the renderer boundary keeps the queued view,
cellbuf, terminal output, and the subsequent scroll calculation on the same frame.Fixes #1736.
Downstream regression and integration coverage: genai-io/san#401
Testing
go test ./...go test -race ./...