test: stabilize view model golden output - #1752
Open
jackwalkerlabs wants to merge 1 commit into
Open
Conversation
|
Thanks for picking this up. I'd proposed this fix in #1746 and had it on a branch, so I'm glad either way as long as it lands. One suggestion for the PR body: it's worth stating explicitly that the golden files are unchanged. That's the part that shows the recorded ordering was always correct and only the timing was unstable, which makes the fix easier to review than if it came with regenerated testdata. |
Author
|
Good point鈥攗pdated the PR body to state explicitly that the golden files are unchanged. Thanks for confirming the direction. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1746.
TestViewModelcompares the complete terminal output against golden files, but its program uses the default 60 FPS renderer ticker. Under the race detector withGOMAXPROCS=1, that ticker can flush an intermediate frame beforeQuitis handled, making valid renderer timing change the escape-sequence ordering.Run this short golden-output test at 1 FPS so the asynchronous renderer tick stays outside the test window. Production behavior is unchanged, and the existing golden files remain unchanged.
Validation:
go test -race -count 1000 -cpu 1 -run TestViewModel ./...go test -race -count 4 -cpu 1,4 ./...go run github.com/golangci/golangci-lint/v2/cmd/golangci-lint@v2.9.0 rungit diff --check