fix: avoid blocking Program.Print methods after exit - #1758
Open
Ricardo-M-L wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
Friendly ping — this is a small, isolated fix with no behavioral changes beyond preventing deadlocks on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Program.PrintlnandProgram.Printfsend directly to the unbufferedp.msgschannel. AfterRunreturns, the event loop is gone and there is no receiver, so either method blocks forever when called during late goroutine cleanup or after program shutdown.This differs from
Program.Send, which already documents and implements post-exit calls as a no-op by selecting on the program context.Fix
Route both print methods through
Program.Sendand document the post-exit behavior. Printing while the program is running is unchanged; after exit the methods now return instead of leaking or deadlocking a goroutine.The regression test runs a program to completion and verifies both methods return. Against
main, each call remains blocked onp.msgs.Validation
go test -run TestProgramPrintAfterExit -count=100 ./...go test -race -run TestProgramPrintAfterExit -count=50 ./...go test ./...go test -race -count=1 ./...go vet ./...go test ./...inexamples/go run github.com/golangci/golangci-lint/v2/cmd/golangci-lint@v2.9.0 rungit diff --checkI have read CONTRIBUTING.md.