fix(logging): preserve Unicode prefix spacing - #1759
Open
Ricardo-M-L wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
Friendly ping — this is a minimal cosmetic fix preserving Unicode prefix spacing in log output. No functional changes. Any feedback welcome! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
LogToFileWithpromises to append an ASCII space only when the supplied prefix does not already end in whitespace. It currently inspects the final byte and converts that byte to a rune:That works for ASCII but misreads every multibyte trailing rune. Prefixes ending in valid Unicode whitespace such as U+00A0 NO-BREAK SPACE or U+3000 IDEOGRAPHIC SPACE therefore receive an unwanted extra ASCII space.
Fix
Decode the final UTF-8 rune before applying
unicode.IsSpace. ASCII behavior stays unchanged, while multibyte whitespace now follows the documented rule.The table-driven regression test covers empty prefixes, missing and existing ASCII spaces, U+00A0, and U+3000.
Validation
go test -run TestLogToFile -count=100 ./...go test -race -run TestLogToFile -count=20 ./...go test ./...go test -race -count=1 ./...go vet ./...go test ./...inexamples/go run github.com/golangci/golangci-lint/v2/cmd/golangci-lint@v2.9.0 rungit diff --checkI have read CONTRIBUTING.md.