fix: do not override a forced color profile with a capability report - #1773
Open
s-johri wants to merge 1 commit into
Open
fix: do not override a forced color profile with a capability report#1773s-johri wants to merge 1 commit into
s-johri wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
WithColorProfiledocuments that it forces a color profile, but the event loopreplaces that profile when the terminal answers a capability request:
Programkeeps no record of where the profile came from, so this code cannottell a caller's choice from a detected value. It overwrites both.
Repro
The new test drives the same path with
p.Send(CapabilityMsg{Content: "RGB"}).Fix
Record that the profile came from the option, then skip the upgrade. Detection
is unchanged, and a program that does not use the option behaves as before.
Found while mapping
NO_COLORtoNoTTY. It also affects tests that pin aprofile, which the v2 upgrade guide recommends, and applications with their own
"color: off" setting.
Note for the reviewer
ColorProfileMsgis not sent when the profile is forced, because the profiledoes not change. Tell me if you prefer to send it anyway.