Fix possible fix(deps): 2 vulnerable dependencies in go.mod - #283
Closed
begininvoke wants to merge 1 commit into
Closed
Fix possible fix(deps): 2 vulnerable dependencies in go.mod#283begininvoke wants to merge 1 commit into
begininvoke wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates Go module dependencies in go.mod to address a reported vulnerability (CVE‑2026‑46600) in golang.org/x/net by moving to newer x/* versions.
Changes:
- Bumps
golang.org/x/net(andgolang.org/x/text) to newer versions to mitigate the referenced CVE. - Adjusts several other dependencies (notably
testifyandprotobuf) and updates the indirect dependency set (including YAML module path changes).
Suppressed comments (2)
go.mod:32
google.golang.org/protobufwas changed from the tagged releasev1.36.12to the pre-release pseudo-versionv1.36.12-0..., which is semver-ordered beforev1.36.12(i.e., a downgrade). Unless there’s a specific advisory requiring this commit, prefer the tagged release (or a newer tag).
google.golang.org/protobuf v1.36.12-0.20260120151049-f2248ac996af
go.mod:70
go.modwas updated (x/net, x/text, testify/protobuf, yaml, etc.), butgo.sumis still pinned to the prior versions (e.g., it still hasgolang.org/x/net v0.55.0,golang.org/x/text v0.38.0,testify v1.12.1,protobuf v1.36.12). CI runstask verify-vendor(which runsgo mod tidy && go mod verify) and will fail until the resultinggo.sumupdates (and any related module metadata updates) are committed.
golang.org/x/net v0.56.0 // indirect
golang.org/x/text v0.39.0 // indirect
google.golang.org/genproto/googleapis/rpc v0.0.0-20260526163538-3dc84a4a5aaa // indirect
gopkg.in/yaml.v3 v3.0.1 // indirect
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposing a fix for something flagged in
go.mod. It is around line 1.The project pins golang.org/x/net at v0.55.0, which contains CVE‑2026‑46600. A malformed SVCB or HTTPS DNS resource record can cause the parser to panic due to a buffer overflow, leading to a potential denial‑of‑service. This is classified as HIGH severity because it can be triggered remotely and cause service disruption.
Update vulnerable dependencies to latest versions per advisory.
For reference: rule
CVE-2026-46600. Rated high.I do not know the codebase, so please check the change fits how the rest of it works. Happy to adjust it or close this if the reasoning is off.
Found with automated scanning (RedGem) and reviewed before opening. If it is not useful, closing it is completely fine.