Skip to content

Fix possible fix(deps): 2 vulnerable dependencies in go.mod - #283

Closed
begininvoke wants to merge 1 commit into
containerd:mainfrom
begininvoke:redgem/security-fix-3745e6b2
Closed

Fix possible fix(deps): 2 vulnerable dependencies in go.mod#283
begininvoke wants to merge 1 commit into
containerd:mainfrom
begininvoke:redgem/security-fix-3745e6b2

Conversation

@begininvoke

Copy link
Copy Markdown

Proposing a fix for something flagged in go.mod. It is around line 1.

The project pins golang.org/x/net at v0.55.0, which contains CVE‑2026‑46600. A malformed SVCB or HTTPS DNS resource record can cause the parser to panic due to a buffer overflow, leading to a potential denial‑of‑service. This is classified as HIGH severity because it can be triggered remotely and cause service disruption.

Update vulnerable dependencies to latest versions per advisory.

For reference: rule CVE-2026-46600. Rated high.

I do not know the codebase, so please check the change fits how the rest of it works. Happy to adjust it or close this if the reasoning is off.


Found with automated scanning (RedGem) and reviewed before opening. If it is not useful, closing it is completely fine.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates Go module dependencies in go.mod to address a reported vulnerability (CVE‑2026‑46600) in golang.org/x/net by moving to newer x/* versions.

Changes:

  • Bumps golang.org/x/net (and golang.org/x/text) to newer versions to mitigate the referenced CVE.
  • Adjusts several other dependencies (notably testify and protobuf) and updates the indirect dependency set (including YAML module path changes).
Suppressed comments (2)

go.mod:32

  • google.golang.org/protobuf was changed from the tagged release v1.36.12 to the pre-release pseudo-version v1.36.12-0..., which is semver-ordered before v1.36.12 (i.e., a downgrade). Unless there’s a specific advisory requiring this commit, prefer the tagged release (or a newer tag).
	google.golang.org/protobuf v1.36.12-0.20260120151049-f2248ac996af

go.mod:70

  • go.mod was updated (x/net, x/text, testify/protobuf, yaml, etc.), but go.sum is still pinned to the prior versions (e.g., it still has golang.org/x/net v0.55.0, golang.org/x/text v0.38.0, testify v1.12.1, protobuf v1.36.12). CI runs task verify-vendor (which runs go mod tidy && go mod verify) and will fail until the resulting go.sum updates (and any related module metadata updates) are committed.
	golang.org/x/net v0.56.0 // indirect
	golang.org/x/text v0.39.0 // indirect
	google.golang.org/genproto/googleapis/rpc v0.0.0-20260526163538-3dc84a4a5aaa // indirect
	gopkg.in/yaml.v3 v3.0.1 // indirect

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread go.mod
Comment on lines 1 to 2
module github.com/containerd/nerdbox

go 1.26.3
Comment thread go.mod
github.com/moby/sys/userns v0.1.0
github.com/opencontainers/runtime-spec v1.3.0
github.com/stretchr/testify v1.12.1
github.com/stretchr/testify v1.11.1
@dmcgowan dmcgowan closed this Aug 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants