persist metadata to skip remote reads on restart in DB mode - #2229
Open
wswsmao wants to merge 1 commit into
Open
persist metadata to skip remote reads on restart in DB mode#2229wswsmao wants to merge 1 commit into
wswsmao wants to merge 1 commit into
Conversation
Signed-off-by: abushwang <abushwang@tencent.com>
Contributor
Author
ktock
reviewed
Apr 14, 2026
Comment on lines
+442
to
+459
| keep := make(map[string]struct{}) | ||
| if err := storage.WalkInfo(txCtx, func(ctx context.Context, info snapshots.Info) error { | ||
| if _, ok := info.Labels[remoteLabel]; !ok { | ||
| return nil | ||
| } | ||
| if dgst, ok := info.Labels[targetStargzLayerDigestLabel]; ok && dgst != "" { | ||
| keep[dgst] = struct{}{} | ||
| } | ||
| if dgst, ok := info.Labels[targetCRILayerDigestLabel]; ok && dgst != "" { | ||
| keep[dgst] = struct{}{} | ||
| } | ||
| return nil | ||
| }); err != nil { | ||
| log.G(ctx).WithError(err).Warn("failed to walk snapshots for metadata prune") | ||
| return | ||
| } | ||
|
|
||
| if err := p.PruneMetadata(ctx, keep); err != nil { |
Member
There was a problem hiding this comment.
Why are the stargz layer digests explicitly passed to the PruneMetadata? Doesn't the db track only the stargz layers already?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: #2228
test case: