fix(math): remove redundant allocations in MinInt and MaxInt - #26781
Open
Radovenchyk wants to merge 1 commit into
Open
fix(math): remove redundant allocations in MinInt and MaxInt#26781Radovenchyk wants to merge 1 commit into
Radovenchyk wants to merge 1 commit into
Conversation
Contributor
|
PR author is not in the allowed authors list. |
Radovenchyk
force-pushed
the
fix/minint-maxint-aliasing
branch
from
August 27, 2026 10:02
387d7ec to
a9af62a
Compare
Fix aliasing bug in MinInt and MaxInt — result no longer shares internal pointer with inputs.
Radovenchyk
force-pushed
the
fix/minint-maxint-aliasing
branch
from
August 27, 2026 10:10
a9af62a to
276b1c3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes a redundant allocation in MinInt and MaxInt the min/max helpers already return a fresh big.Int copy, so the extra new(big.Int).Set(...) wrapper was unnecessary. The result still doesn't share its internal pointer with the inputs (verified by TestMinMaxIntAliasing).