Replace get_document_revision_public with get_user_client - #516
Open
torcolvin wants to merge 1 commit into
Open
Conversation
- Add a `revision` param to get_document and a get_user_client helper for already existing users, then drop the now-unused session= param on _send_request and SyncGateway's duplicate __public_port field. Create accessor since using __<var> means the attributes are not accessible from superclasses. - replace assertion about exception with pytest.raises to ensure that it raises the exception
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
revisionparam to get_document and a get_user_client helper for already existing users, then drop the now-unused session= param on _send_request and SyncGateway's duplicate __public_port field. Create accessor since using __ means the attributes are not accessible from superclasses.Drops some complexity around session creation and moves things to more logical locations to indicate that this is a user client and which user client.