fix: zero-initialize m_RefractiveIndex, out-of-bounds access guards - #61
Open
veprbl wants to merge 2 commits into
Open
fix: zero-initialize m_RefractiveIndex, out-of-bounds access guards#61veprbl wants to merge 2 commits into
veprbl wants to merge 2 commits into
Conversation
veprbl
changed the title
11 tasks
Member
Author
|
@alexander-kiselev Any objections to this? |
veprbl
force-pushed
the
pr/zeroptr
branch
2 times, most recently
from
September 4, 2026 19:43
5ed749d to
dd01eb1
Compare
Collaborator
|
Approved |
veprbl
enabled auto-merge (rebase)
September 4, 2026 23:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug 1
Garbage in the pointer leads to crashes in
IrtInterface::~IrtInterface()whenrindex_matrixis not available andrad->m_RefractiveIndexis not initialized.https://github.com/eic/EICrecon/blob/e689e99d30cfd4c4e47ad10ab99ea828ae38db1b/src/algorithms/pid/IrtInterface.cc#L88-L100
https://github.com/eic/EICrecon/blob/e689e99d30cfd4c4e47ad10ab99ea828ae38db1b/src/algorithms/pid/IrtInterface.cc#L61-L62
Bug 2
The
ibin >= _THETA_BIN_COUNT_check is more of a defensive measure for hypothetical theta=pi case.The check for
m_AverageRefractiveIndicesis needed to avoid hitting calibration region bound, and is practical in some events: