fix(bundler-plugins): Stamp debug IDs onto emitted source maps when disable-upload is set - #23754
Draft
msonnb wants to merge 2 commits into
Draft
fix(bundler-plugins): Stamp debug IDs onto emitted source maps when disable-upload is set#23754msonnb wants to merge 2 commits into
disable-upload is set#23754msonnb wants to merge 2 commits into
Conversation
Contributor
size-limit report 📦
|
Member
Author
|
bugbot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 0637f26. Configure here.
msonnb
force-pushed
the
ms/bundler-plugins-disable-upload-fix
branch
from
August 31, 2026 11:45
0637f26 to
532bb7f
Compare
…disable-upload` is set
msonnb
force-pushed
the
ms/bundler-plugins-disable-upload-fix
branch
from
September 1, 2026 09:10
532bb7f to
c9e7549
Compare
Member
Author
|
bugbot run |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit c9e7549. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sourcemaps.disable: 'disable-upload'now stamps the debug ID onto the emitted artifacts://# debugId=comment in the bundle anddebug_id/debugIdin the.js.map. Previously only the temp copies made for uploading were stamped, so with the upload skipped the emitted files carried no debug ID and the documented "upload manually later" workflow didn't work.Stamping runs inside the bundler's asset pipeline: webpack
processAssetsright afterSourceMapDevToolPlugin(beforeRealContentHashPluginand SRI plugins, regardless of plugin order), and rollup/vitegenerateBundle(after minification; Vite runs it before core/normal/post plugins since the plugin isenforce: 'pre'; in plain rollup, plugins listed before Sentry that hash ingenerateBundlewon't see the stamp). esbuild has no such hook, so outputs are rewritten on disk inonEnd—[hash]names and earlier-registeredonEndhashers won't reflect it.Fixes getsentry/sentry-javascript-bundler-plugins#949
Fixes getsentry/sentry-javascript-bundler-plugins#603