feat(nuxt): Register a route provider outside the tracing guard - #23794
Draft
logaretm wants to merge 1 commit into
Draft
feat(nuxt): Register a route provider outside the tracing guard#23794logaretm wants to merge 1 commit into
logaretm wants to merge 1 commit into
Conversation
Nuxt installs the router before its plugins run, so the client plugin can read it straight off `nuxtApp` rather than waiting for a Vue app the way `@sentry/vue` does. Registered outside the `__SENTRY_TRACING__` guard, so route parameterization survives when tracing is tree-shaken away. Reuses `createVueRouteProvider` rather than reimplementing the vue-router resolve handling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Registers a route provider for Nuxt in the client plugin, outside the
__SENTRY_TRACING__guard.Nuxt installs the router before its plugins run, so the plugin can read it straight off
nuxtApprather than waiting for a Vue app the way@sentry/vuehas to. ReusescreateVueRouteProviderfrom #23553's successor rather than reimplementing the vue-router resolve handling.Because it sits outside the tracing guard, route parameterization survives when tracing is tree-shaken away.
Part of #23556