[rig-claude] Improve Claude dynamic-workflow compatibility for rig - #514
Draft
github-actions[bot] wants to merge 1 commit into
Draft
[rig-claude] Improve Claude dynamic-workflow compatibility for rig#514github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
Promise.all bypasses the shared concurrency limiter, which breaks the Claude dynamic-workflow porting contract. Update the primitive mapping to make the cast approach primary and warn against Promise.all in workflow bodies. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compatibility gap addressed
The
parallelprimitive mapping inskills/rig/references/claude-workflow-conversion.mdpreviously recommendedPromise.allas the fallback for heterogeneous agent output types. This is misleading:Promise.allbypasses the shared concurrency limiter and skips thenull-hole failure model thatparallelprovides — both of which are semantically important when porting from Claude dynamic workflows.Why this improves transfer from Claude dynamic workflows to rig
Claude dynamic workflows'
parallel(thunks)always runs inside the limiter. A developer who ports to rig and follows the old guidance (use Promise.all) gets silently different behavior: unlimited concurrency and exceptions propagating instead ofnullholes. The fix makes the cast approach the recommended path and adds an explicit warning aboutPromise.all.Files changed
skills/rig/references/claude-workflow-conversion.md— updated theparallel(thunks)row in the primitive mapping tableValidation
Docs-only change; no code was modified. No additional validation beyond reviewing the edited file for broken links (none found).
Remaining intentional differences
All existing intentional differences documented in the file are preserved. No new differences introduced.