Add ability to deploy image using sha256 digest, not floating label - #135
Open
tpayne wants to merge 1 commit into
Open
Add ability to deploy image using sha256 digest, not floating label#135tpayne wants to merge 1 commit into
tpayne wants to merge 1 commit into
Conversation
tpayne
requested review from
autero1,
rhoboat,
yorinasub17 and
zackproser
as code owners
May 10, 2022 12:23
Contributor
|
Thanks for the PR @tpayne! |
Author
|
Thanks for the comments. I'll try and add these over the next week or so. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change is to allow the
containerImage.tagkey to support both SHA256 digest image values as well as standard tag labels likemasterorlatest.When a SHA256 value is specified, then the
_deployment_spec.tplwill generate an image line like...image: "nginx@sha256:15b5f7f28672bbbf26f058928b16ecb465843845fafe5ea9a06b05a590709150"rather than...
image: "nginx:latest"The change is fully backward compatible with existing tag usage.
Tested by running the "-tag tpl" go test scripts, plus the following...
run1.txt
run2.txt
Documentation
Updates have been made to the
helm-kubernetes-services/charts/k8s-service/README.mdto describe the change and the use-cases that you might want to use it for.This includes a code snippet on usage.
TODOs
Please ensure all of these TODOs are completed before asking for a review.
feature/new-vpc-endpoints-955orbug/missing-count-param-434.Related Issues