fix(security): resolve CodeQL code scanning alerts - #1624
Open
FenjuFu wants to merge 3 commits into
Open
Conversation
Signed-off-by: Fenju Fu <92919259+FenjuFu@users.noreply.github.com>
Signed-off-by: Fenju Fu <92919259+FenjuFu@users.noreply.github.com>
Signed-off-by: Fenju Fu <92919259+FenjuFu@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
py/weak-sensitive-data-hashingfalse positives at the sourceCodeQL alert disposition
java/ssrf(critical): fixed. The connection now uses a per-request DNS implementation that rejects restricted answers and pins the accepted result for the lifetime of the request.py/weak-sensitive-data-hashing(high): false positive. SHA-256 is used as the digest algorithm for HMAC request authentication, not for password storage.py/weak-sensitive-data-hashing(high): protocol-required. The upstream Spark RTASR protocol specifiesHmacSHA1(MD5(appid + ts), api_key);appidand the timestamp are protocol metadata rather than stored secrets. See the official API documentation.The source retains auditable CodeQL rationale. With maintainer approval, false-positive alerts #48, #55, and PR alert #63 were dismissed through the REST API with technical audit comments. The real default-branch alert #54 remains open until this PR is merged.
Validation
mvn -pl toolkit -am -Dtest=UrlCheckToolTest -Dsurefire.failIfNoSpecifiedTests=false test? 12 passedmvn -pl toolkit -am spotless:check? passeduv run --frozen python -m pytest tests/test_utils.py -q? 14 passedIrrzsJeOFk1NGfJHW6SkHUoN9CU=black --checkon both changed Python files ? passedgit diff --check? passed