Skip to content

fix(security): resolve CodeQL code scanning alerts - #1624

Open
FenjuFu wants to merge 3 commits into
iflytek:mainfrom
FenjuFu:fix/code-scanning-alerts
Open

fix(security): resolve CodeQL code scanning alerts#1624
FenjuFu wants to merge 3 commits into
iflytek:mainfrom
FenjuFu:fix/code-scanning-alerts

Conversation

@FenjuFu

@FenjuFu FenjuFu commented Aug 18, 2026

Copy link
Copy Markdown
Member

Summary

  • eliminate the DNS-rebinding time-of-check/time-of-use gap in redirect probing by validating and pinning the exact DNS answers used by OkHttp
  • bypass system proxies for the security probe so the validated target cannot be resolved independently by a proxy
  • add regression coverage for rebinding and restricted-address rejection
  • document and suppress two py/weak-sensitive-data-hashing false positives at the source

CodeQL alert disposition

The source retains auditable CodeQL rationale. With maintainer approval, false-positive alerts #48, #55, and PR alert #63 were dismissed through the REST API with technical audit comments. The real default-branch alert #54 remains open until this PR is merged.

Validation

  • mvn -pl toolkit -am -Dtest=UrlCheckToolTest -Dsurefire.failIfNoSpecifiedTests=false test ? 12 passed
  • mvn -pl toolkit -am spotless:check ? passed
  • uv run --frozen python -m pytest tests/test_utils.py -q ? 14 passed
  • official Spark signature vector ? matched IrrzsJeOFk1NGfJHW6SkHUoN9CU=
  • black --check on both changed Python files ? passed
  • git diff --check ? passed

Signed-off-by: Fenju Fu <92919259+FenjuFu@users.noreply.github.com>
Signed-off-by: Fenju Fu <92919259+FenjuFu@users.noreply.github.com>
Signed-off-by: Fenju Fu <92919259+FenjuFu@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants