Skip to content

add test cases - #21

Open
misogihagi wants to merge 2 commits into
kn1cht:masterfrom
misogihagi:master
Open

add test cases#21
misogihagi wants to merge 2 commits into
kn1cht:masterfrom
misogihagi:master

Conversation

@misogihagi

Copy link
Copy Markdown
Contributor

id does not work

@kn1cht

kn1cht commented Mar 10, 2024

Copy link
Copy Markdown
Owner

@misogihagi Thank you for pointing this out!
When I coded this rule, I assumed that if there was a space between a number and a word, it was determined to be a number with units.
However, this assumption does not work except for languages like Japanese that do not separate words by spaces.

To remedy this, we need to fundamentally redesign the method of determining units, which will take quite some time.
I will find time to work on it, so I hope you can wait a while until then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants