enhance: recreate field indexes with safety checks - #536
Open
weiliu1031 wants to merge 1 commit into
Open
Conversation
issue: #261 Operators need a controlled way to rebuild an existing field index without waiting for compaction. Add a dry-run-first command that reads the selected index definition, preserves its name and user parameters, then drops and recreates it only after explicit execution. The command can opt into AUTOINDEX or release and reload the collection. Reloading requires explicit acknowledgement because LoadCollection uses server defaults instead of the previous load configuration. Completion now resolves collections, fields, and index names from the connected cluster. Validation: - gofmt on all changed Go files - git diff --check - go vet ./states/autocomplete ./internal/ops ./states/milvusctl - go build ./states/autocomplete ./internal/ops ./states/milvusctl - go build -o /tmp/birdwatcher-recreate-index cmd/birdwatcher/main.go - Unit tests not run because the required local Milvus reset binary is unavailable. Signed-off-by: Wei Liu <wei.liu@zilliz.com>
Collaborator
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: weiliu1031 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Tick the box to add this pull request to the merge queue (same as
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
issue: #261
What changed
recreate indexcommand for a collection field.or recreate it with AUTOINDEX through
--auto-index.--release-and-load.Safety behavior
release/reload was explicitly requested.
--confirm-default-loadbecause automatic reload uses server-defaultsettings and cannot preserve the previous replica count, resource groups,
load fields, or dynamic-field behavior.
DescribeIndexexposes only legacy fallbackparameters that might not reproduce the original physical index.
Validation
gofmton all changed Go filesgit diff --checkgo vet ./states/autocomplete ./internal/ops ./states/milvusctlgo build ./states/autocomplete ./internal/ops ./states/milvusctlgo build -o /tmp/birdwatcher-recreate-index cmd/birdwatcher/main.goUnit tests were not run because the local Milvus binary required by the
mandatory reset workflow is unavailable.