This repository was archived by the owner on May 26, 2026. It is now read-only.
feat: Refactor the log library of milvus, support scoped context logging - #14
Open
chyezh wants to merge 1 commit into
Open
feat: Refactor the log library of milvus, support scoped context logging#14chyezh wants to merge 1 commit into
chyezh wants to merge 1 commit into
Conversation
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: chyezh The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Signed-off-by: chyezh <chyezh@outlook.com>
xiaofan-luan
pushed a commit
to milvus-io/milvus
that referenced
this pull request
May 21, 2026
…ogging (#47610) issue: #35917 design doc: milvus-io/milvus-design-docs#14 Summary This PR implements the mlog package - a context-aware logging library built on https://github.com/uber-go/zap, designed specifically for Milvus distributed systems. Key Features - Mandatory Context Passing - All logging operations require a context, ensuring request traceability - Zero-Overhead Abstraction - Uses type aliases to avoid wrapper overhead, performance comparable to direct zap usage - Automatic Field Accumulation - Context fields automatically accumulate through the call chain, child contexts inherit parent fields - Cross-Service Propagation - Supports propagating key fields via gRPC metadata for distributed tracing - Lazy Encoding - Uses WithLazy for deferred field encoding, avoiding encoding overhead when log level is disabled - Component-Level Logger - Provides optimized Logger type that selects the logger with more pre-encoded fields to minimize runtime encoding --------- Signed-off-by: chyezh <chyezh@outlook.com> Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
issue: milvus-io/milvus#35917
Summary
This PR implements the mlog package - a context-aware logging library built on
https://github.com/uber-go/zap, designed specifically for Milvus distributed systems.
Key Features
Mandatory Context Passing - All logging operations require a context, ensuring request traceability
Zero-Overhead Abstraction - Uses type aliases to avoid wrapper overhead, performance comparable to
direct zap usage
Automatic Field Accumulation - Context fields automatically accumulate through the call chain, child
contexts inherit parent fields
Cross-Service Propagation - Supports propagating key fields via gRPC metadata for distributed tracing
Lazy Encoding - Uses WithLazy for deferred field encoding, avoiding encoding overhead when log level
is disabled
Component-Level Logger - Provides optimized Logger type that selects the logger with more pre-encoded
fields to minimize runtime encoding