enhance: revert the bulk import idempotency key fields - #657
Open
bigsheeper wants to merge 1 commit into
Open
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: bigsheeper The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Tick the box to add this pull request to the merge queue (same as
|
bigsheeper
force-pushed
the
revert/bulk-import-idempotency-key
branch
from
August 25, 2026 06:36
11c7f51 to
2e99f3b
Compare
Reverts the two fields added in milvus-io#633. The implementation that needed them (milvus-io/milvus#52544) carries the client key in gRPC metadata and a broadcast message property instead, so no request proto is involved and both fields are unused. Neither field appears in a tagged release, and milvus pins the commit that precedes milvus-io#633, so field numbers 9 and 10 are released back rather than reserved. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
bigsheeper
force-pushed
the
revert/bulk-import-idempotency-key
branch
from
August 27, 2026 07:40
2e99f3b to
d960102
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
issue: milvus-io/milvus#50954
What
Reverts the
idempotency_keyfields added in #633:ImportRequest.idempotency_key = 9(proto/milvus.proto)ImportMsg.idempotency_key = 10(proto/msg.proto)Why
The implementation those fields were added for landed on a different design. milvus-io/milvus#52544 makes broadcast generically idempotent rather than making BulkImport idempotent: the client key travels as gRPC metadata (
idempotency-key) / the RESTIdempotency-Keyheader, is copied onto coordinator RPCs by a shared unary client interceptor, and reaches the broadcaster as a message property. No request proto carries it, and no message body field is read.Both fields are therefore unused. Neither is referenced by any Go code in milvus master today, and milvus pins
v3.0.0-20260806081414-16b288837fbd— the commit immediately preceding #633 — so the fields have never been consumed.Field numbers
9and10are released rather thanreserved.git tag --contains 9810b92is empty: no tagged release of this repo ever exposed them, so no consumer can hold a wire encoding that uses them. Say the word if you would rather reserve them anyway and I will add thereservedentries.Changes
proto/milvus.protoandproto/msg.proto.go-api/milvuspb/milvus.pb.goandgo-api/msgpb/msg.pb.go.Verification
scripts/proto_gen_go.shinvocations. Control run first: regenerating atorigin/masterwith no source change produced a byte-identical tree, so the diff here is the field removal and nothing else.rawDescportion of the generated diff is exactly the two struct fields and their two getters; the rest is the descriptor byte array reflowing.go build ./...andgo vet ./milvuspb/... ./msgpb/...clean ingo-api/.🤖 Generated with Claude Code