feat: add analyzed text terms to insert messages - #664
Open
aoiasd wants to merge 1 commit into
Open
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: aoiasd The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@aoiasd Please associate the related issue to the body of your Pull Request. (eg. “issue: #6534”) |
|
Tick the box to add this pull request to the merge queue (same as
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
issue: milvus-io/milvus#50921
design: milvus-io/milvus#51952
What
Add a field-scoped
TextTermBatchsidecar toInsertRequest. Each batch identifies the text input field and carries the analyzed terms that the producer sorted and deduplicated for that insert message.Why
Milvus fuzzy BM25 needs the original analyzer output to survive WAL transport so flush and growing recovery can build the same segment term dictionary as the BM25 function. Multi-analyzer row dispatch shares one field vocabulary, so the sidecar intentionally has no analyzer namespace. User-facing fuzzy settings continue to use existing Function and search parameter containers.
Verification
make generate-proto(cd go-api && go test ./...)(cd go-api && go vet ./...)git diff --check upstream/master...HEAD