feat: [3.0] add PrivilegeImportBinlog object privilege - #665
Open
bigsheeper wants to merge 1 commit into
Open
Conversation
Binlog import (import option backup=true) and L0 import read Milvus's own internal storage layout rather than a caller staging area, which is outside the target collection's namespace. Add a cluster-level privilege so that capability can be authorized separately from the collection-level Import privilege. Keeps the master enum value 94 rather than the next free number on this branch (91), so the same privilege has one wire value across versions. 91-93 stay reserved for the RLS privileges that master already uses. pr: milvus-io#643 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: bigsheeper The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Tick the box to add this pull request to the merge queue (same as
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pr: #643
Back-port of the enum added on master by #643, needed by the 3.0 back-port of milvus-io/milvus#51894.
What
Adds a cluster-level
PrivilegeImportBinlogtoObjectPrivilege. Binlog import (backup=true) and L0 import read Milvus's own internal storage layout rather than a caller staging area, i.e. outside the target collection's namespace, so that capability is authorized separately from the collection-levelImportprivilege.Enum value
94, matching master, rather than91— the next free number on this branch.This branch's
ObjectPrivilegecurrently stops atPrivilegeExportSnapshot = 90; master continuesPrivilegeSkipRLS = 91,PrivilegeViewRLS = 92,PrivilegeManageRLS = 93,PrivilegeImportBinlog = 94. Taking91here would give the same privilege two different wire values across versions and would collide withPrivilegeSkipRLSif the RLS privileges are later back-ported.91-93are left as gaps reserved for them.Generation
go-api/commonpb/common.pb.goregenerated with protoc 3.21.4 / protoc-gen-go 1.33.0, matching the header already in the file. The change is three semantic lines (enum constant, name map, value map) plus the raw descriptor bytes.