Skip to content

fix: refresh loads in async client - #3779

Closed
mikemikimike wants to merge 1 commit into
milvus-io:masterfrom
mikemikimike:codex/issue-3772-async-refresh-load
Closed

fix: refresh loads in async client#3779
mikemikimike wants to merge 1 commit into
milvus-io:masterfrom
mikemikimike:codex/issue-3772-async-refresh-load

Conversation

@mikemikimike

Copy link
Copy Markdown

Closes #3772

AsyncMilvusClient.refresh_load() currently delegates to the low-level progress query instead of requesting a load refresh. As a result, async callers and optimize_collection() can return without reloading refreshed segments.

This change reuses the existing async load paths: collections call load_collection(..., _refresh=True), while partition refreshes call load_partitions(..., _refresh=True). Regression tests verify both routes and ensure the progress-only handler is not used.

Validation: async client unit tests passed (81); Ruff format/check and git diff --check passed. A targeted mypy run is blocked by existing missing grpc/milvus-lite stubs and generated protobuf stub syntax errors.

This contribution was prepared with assistance from an AI agent.

Signed-off-by: mikemikimike <13286568797@163.com>
@sre-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mikemikimike
To complete the pull request process, please assign tedxu after the PR has been reviewed.
You can assign the PR to them by writing /assign @tedxu in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify

mergify Bot commented Aug 29, 2026

Copy link
Copy Markdown

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

@linhongyu510

Copy link
Copy Markdown

I checked out this PR in an isolated worktree and ran the complete async client operations test module with the PR source forced on PYTHONPATH:

pytest tests/unit/test_async_milvus_client_ops.py -q
81 passed, 3 warnings

Both new regression cases pass:

  • collection refresh delegates to load_collection(..., _refresh=True);
  • partition refresh delegates to load_partitions(..., _refresh=True).

I also verified that the progress-only handler is not used by either path. I did not find a correctness issue in the changed scope.

@mikemikimike
mikemikimike deleted the codex/issue-3772-async-refresh-load branch August 31, 2026 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: AsyncMilvusClient.refresh_load() never triggers a refresh, so optimize_collection() leaves stale segments loaded

3 participants