fix(viewer): sort checks by name within risk levels - #1014
Open
bilaldeveloper4312 wants to merge 1 commit into
Open
fix(viewer): sort checks by name within risk levels#1014bilaldeveloper4312 wants to merge 1 commit into
bilaldeveloper4312 wants to merge 1 commit into
Conversation
✅ Deploy Preview for ossf-scorecard ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
bilaldeveloper4312
force-pushed
the
agent/sort-checks-by-name-within-risk
branch
from
August 11, 2026 15:10
e2f75bf to
789cd5c
Compare
bilaldeveloper4312
marked this pull request as ready for review
August 13, 2026 07:10
bilaldeveloper4312
requested review from
AdamKorcz,
UlisesGascon and
justaugustus
August 13, 2026 07:10
Signed-off-by: Muhammad Bilal Mukhtar <119035493+bilaldeveloper4312@users.noreply.github.com>
bilaldeveloper4312
force-pushed
the
agent/sort-checks-by-name-within-risk
branch
from
August 24, 2026 11:10
789cd5c to
989f0f6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The risk-level comparator currently uses numeric score as its tie-breaker, so checks in the same risk category appear in an inconsistent, non-alphabetical order. Using the check name as the tie-breaker makes the result predictable while preserving the selected risk-level direction.
Fixes #430.
Verification
git diff --checkThe viewer does not currently have a dedicated unit-test suite for this inline comparator.