Bump the version in all four files that carry it - #86
Open
teknogeek0 wants to merge 1 commit into
Open
Conversation
bump_version.sh updated only VERSION and setup.py. pyproject.toml and planetscale_discovery/__init__.py also carry the version, and both were left at 1.3.0 during the v1.3.1 release. The release workflow compares the tag against VERSION only, so it does not catch this. The script now updates all four files and stops with an error if any file still holds the old version. RELEASING.md matches.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bump_version.sh updated only VERSION and setup.py, so pyproject.toml and planetscale_discovery/init.py were left at 1.3.0 through the v1.3.1 release. It now updates all four and fails if any file still holds the old version.