refactor(tools): extract function for basicEnvVars docs - #45426
Merged
jamietanna merged 5 commits intoAug 24, 2026
Conversation
jamietanna
force-pushed
the
feat/default-ci-1-test-strict
branch
from
August 24, 2026 14:01
b1f0fc9 to
1ca1802
Compare
jamietanna
force-pushed
the
feat/default-ci-2-extract-fn
branch
from
August 24, 2026 14:01
62030b2 to
5e71831
Compare
viceice
previously approved these changes
Aug 24, 2026
As we'll be adding more functionality into this file, and extracting the function helps keep it clearer what's being done in the function scope.
As noted in #43761, we had recently set `CI=true` for the Renovate and Containerbase orgs on Mend-hosted apps due to a pnpm v11 requirement: ERR_PNPM_ABORTED_REMOVE_MODULES_DIR_NO_TTY Aborted removal of modules directory due to no TTY If you are running pnpm in CI, set the CI environment variable to "true", or set "confirmModulesPurge" to "false". Similarly in #43606, it was noted that we should do this for `mise lock` to mark the workspace as "trusted". Although we went with a different situation, there will be cases where this is useful for tools being executed, for instance when we invoke `yarn`. We also make sure to keep our documentation up-to-date as we add to the specific overrides. With help from Claude Sonnet and Opus to: - perform some of the mechanical updates as part of this change - ensure that the Docker sidecar always has `hardcodedProcessEnv` passed into it - catch a needed change to `exposeAllEnv` handling Co-authored-by: Claude Opus 5 <jamie.tanna+claude-code@mend.io> Co-authored-by: Claude Sonnet 5 <jamie.tanna+claude-code@mend.io>
As part of follow-up changes, it was noticed that our mocking of `getChildProcessEnv` means we're not seeing the actual environment variables in our tests. To make sure that future tests can check that `CI` is added as expected by default, we can remove the mocking. Co-Authored-By: Claude Sonnet 5 <jamie.tanna+claude-code@mend.io>
As noted in #43761, we had recently set `CI=true` for the Renovate and Containerbase orgs on Mend-hosted apps due to a pnpm v11 requirement: ERR_PNPM_ABORTED_REMOVE_MODULES_DIR_NO_TTY Aborted removal of modules directory due to no TTY If you are running pnpm in CI, set the CI environment variable to "true", or set "confirmModulesPurge" to "false". Similarly in #43606, it was noted that we should do this for `mise lock` to mark the workspace as "trusted". Although we went with a different situation, there will be cases where this is useful for tools being executed, for instance when we invoke `yarn`. We also make sure to keep our documentation up-to-date as we add to the specific overrides.
As it's now the default.
jamietanna
force-pushed
the
feat/default-ci-1-test-strict
branch
from
August 24, 2026 16:28
1ca1802 to
0d920f1
Compare
jamietanna
force-pushed
the
feat/default-ci-2-extract-fn
branch
from
August 24, 2026 16:28
5e71831 to
8770bff
Compare
jamietanna
merged commit Aug 24, 2026
f50bee3
into
feat/default-ci-1-test-strict
50 of 73 checks passed
Contributor
|
🎉 This PR is included in version 44.42.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
jamietanna
temporarily deployed
to
github-pages
August 25, 2026 07:34 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Context
Please select one of the following:
AI assistance disclosure
Did you use AI tools to create any part of this pull request?
Please select one option and, if yes, briefly describe how AI was used (e.g., code, tests, docs) and which tool(s) you used.
Use of AI in replying to PR comments
Who answers review comments:
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via:
The public repository:
Stack created with GitHub Stacks CLI • Give Feedback 💬