Skip to content

Send user agent for docker update checks - #2724

Open
Mainfrezzer wants to merge 2 commits into
unraid:masterfrom
Mainfrezzer:Mainfrezzer-patch-3
Open

Send user agent for docker update checks#2724
Mainfrezzer wants to merge 2 commits into
unraid:masterfrom
Mainfrezzer:Mainfrezzer-patch-3

Conversation

@Mainfrezzer

@Mainfrezzer Mainfrezzer commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

The docker curl update check doesnt send any user agent and that can end up being blocked (as a lot of botted traffic is user agent less). Docker/dynamix curl actions should clearly identify themselves as such.

Summary by CodeRabbit

  • Bug Fixes
    • Added a Docker/Unraid client identifier to all requests, improving compatibility with connected services.

@github-actions

github-actions Bot commented Aug 14, 2026

Copy link
Copy Markdown

🔧 PR Test Plugin Available

A test plugin has been generated for this PR that includes the modified files.

Version: 2026.08.16.0744
Build: View Workflow Run

📥 Installation Instructions:

Install via Unraid Web UI:

  1. Go to Plugins → Install Plugin
  2. Copy and paste this URL:
https://preview.dl.unraid.net/pr-plugins/pr-2724/webgui-pr-2724.plg
  1. Click Install

Alternative: Direct Download

⚠️ Important Notes:

  • Testing only: This plugin is for testing PR changes
  • Backup included: Original files are automatically backed up
  • Easy removal: Files are restored when plugin is removed
  • Conflicts: Remove this plugin before installing production updates
  • Post-merge behavior: This preview stays available after merge until preview storage expires or it is manually cleaned up

📝 Modified Files:

Click to expand file list
emhttp/plugins/dynamix.docker.manager/include/Helpers.php

🔄 To Remove:

Navigate to Plugins → Installed Plugins and remove webgui-pr-2724, or run:

plugin remove webgui-pr-2724

🤖 This comment is automatically generated and will be updated with each new push to this PR.

@coderabbitai

coderabbitai Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: d3d1e544-756c-4747-aaad-696934bb947e

📥 Commits

Reviewing files that changed from the base of the PR and between ef7b3c5 and 3687862.

📒 Files selected for processing (1)
  • emhttp/plugins/dynamix.docker.manager/include/Helpers.php
💤 Files with no reviewable changes (1)
  • emhttp/plugins/dynamix.docker.manager/include/Helpers.php

Included review availability: Your plan includes up to 2 reviews per rolling hour; 1 remains after this review.


Walkthrough

The shared cURL helper now sets the Docker/Unraid client user agent for requests.

Changes

Docker client identification

Layer / File(s) Summary
cURL user agent configuration
emhttp/plugins/dynamix.docker.manager/include/Helpers.php
getCurlHandle sets the Docker/Unraid client user agent on the shared cURL handle.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 36878

This is a small, localized change to identify Docker update-check requests with a user agent; no actionable merge-blocking risk remains beyond normal checks and review.

Poem

A rabbit set the client name right,
On every curl request in flight.
Docker hops along,
With its label strong,
And keeps its headers light.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: sending a user agent for Docker update checks.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@unraid-bot Unraid Bot (unraid-bot) added QA Passed QA passed (auto-managed by notification-worker) 7.4.0 Approved for release 7.4.0 (auto-managed by notification-worker) and removed 7.4.0 Approved for release 7.4.0 (auto-managed by notification-worker) labels Sep 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

7.4.0 Approved for release 7.4.0 (auto-managed by notification-worker) QA Passed QA passed (auto-managed by notification-worker)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants