common: utils: resolve setting_t data race in mt scenario - #5943
Open
dzarukin wants to merge 1 commit into
Open
Conversation
This fixes openxla/xla#20686 Previous attempts include commits de1c449, e156542, and 763eec4, with the final revert commit 7ebd270. Mutex implementation didn't fly well, this one doesn't seem to cause performance regressions based on preliminary assessment.
Contributor
Author
|
make test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes openxla/xla#20686
Previous attempts include commits de1c449, e156542, and 763eec4, with the final revert commit 7ebd270. Mutex implementation didn't fly well, this one doesn't seem to cause performance regressions based on preliminary assessment.
MFDNN-15491