Fix pf-5, pf-4 CI jobs

[Amoghrd]

Summary by CodeRabbit

• Updated the NetObserv web console pf-4 and pf-5 CI job configurations.
• Removed the 4Gi memory limits while retaining the existing CPU and memory requests.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 16938275-0d7e-4ecf-b032-8455d4cfc50c

📥 Commits

Reviewing files that changed from the base of the PR and between 6b1eb6c and c66e436.

📒 Files selected for processing (2)

• ci-operator/config/netobserv/netobserv-web-console/netobserv-netobserv-web-console-main-pf4__pf4.yaml
• ci-operator/config/netobserv/netobserv-web-console/netobserv-netobserv-web-console-main-pf5__pf5.yaml

💤 Files with no reviewable changes (2)

• ci-operator/config/netobserv/netobserv-web-console/netobserv-netobserv-web-console-main-pf4__pf4.yaml
• ci-operator/config/netobserv/netobserv-web-console/netobserv-netobserv-web-console-main-pf5__pf5.yaml

Included review availability: Your plan provides up to 2 included reviews per hour; 0 remain after this review.

---

Walkthrough

The pf5 Netobserv web console CI configuration removes the default 4Gi memory limit. CPU and memory requests remain unchanged.

Changes

Netobserv resource configuration

Layer / File(s)	Summary
Remove default memory limit ci-operator/config/netobserv/netobserv-web-console/netobserv-netobserv-web-console-main-pf5__pf5.yaml	The default resource profile retains CPU and memory requests and no longer defines a 4Gi memory limit.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to c66e4

This is a narrowly scoped CI configuration cleanup for the pf-4 and pf-5 jobs, with no actionable merge-blocking risk remaining beyond normal checks and review.

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title identifies the affected pf-5 and pf-4 CI jobs and states that the pull request fixes them. It is related to the main configuration change, although it does not describe the removed memory li…
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	PASS. The pull request changes only two CI YAML resource blocks. It removes the static limits.memory: 4Gi entries and does not add or modify Ginkgo test titles or test code. The stable and determini…
Test Structure And Quality	✅ Passed	PASS: The pull request changes only two CI YAML resource profiles. The diff removes limits.memory: 4Gi and makes no changes to Ginkgo test code, test setup or cleanup, waits, or assertions. Therefor…
Microshift Test Compatibility	✅ Passed	PASS: The pull request only removes the limits.memory: 4Gi entries from two CI YAML files. The diff adds no Ginkgo tests and references no MicroShift-incompatible APIs or features. The custom check …
Single Node Openshift (Sno) Test Compatibility	✅ Passed	PASS: The pull request changes only two CI YAML files. It removes limits.memory: 4Gi from resource profiles and adds no Ginkgo tests or test constructs such as It(), Describe(), Context(), or …
Topology-Aware Scheduling Compatibility	✅ Passed	PASS: The pull request changes only two ci-operator YAML resource profiles. The diff removes limits.memory: 4Gi from the '*' CI resource entry and keeps the requests unchanged. It does not modif…
Ote Binary Stdout Contract	✅ Passed	PASS. The commit changes only two CI YAML files. It removes limits.memory: 4Gi from the default resource profile in each file. The diff introduces no OTE binary code, process-level setup, logging, o…
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	PASS: The pull request changes only two CI YAML resource profiles. It removes limits.memory: 4Gi from the '*' resource entry in the pf4 and pf5 configurations. The commit adds no Ginkgo tests, tes…
No-Weak-Crypto	✅ Passed	PASS. The pull request changes only two CI YAML files. It removes memory resource limits from the pf4 and pf5 profiles. The patch introduces no MD5, SHA1, DES, RC4, 3DES, Blowfish, ECB, custom crypto,…
Container-Privileges	✅ Passed	PASS: The pull request changes only two CI YAML files. The diff removes limits.memory: 4Gi from resource entries. It adds no privileged, host namespace, SYS_ADMIN, allowPrivilegeEscalation, ro…
No-Sensitive-Data-In-Logs	✅ Passed	The pull request changes only resource limits in two CI YAML files. The diff removes limits.memory: 4Gi and adds no logging, credentials, identifiers, hostnames, or customer data. The custom check d…

Full details: Title check

Explanation

The title identifies the affected pf-5 and pf-4 CI jobs and states that the pull request fixes them. It is related to the main configuration change, although it does not describe the removed memory limits.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files.

Full details: Stable And Deterministic Test Names

Explanation

PASS. The pull request changes only two CI YAML resource blocks. It removes the static limits.memory: 4Gi entries and does not add or modify Ginkgo test titles or test code. The stable and deterministic test-name check is therefore not triggered.

Full details: Test Structure And Quality

Explanation

PASS: The pull request changes only two CI YAML resource profiles. The diff removes limits.memory: 4Gi and makes no changes to Ginkgo test code, test setup or cleanup, waits, or assertions. Therefore, none of the stated Test Structure and Quality failure conditions apply.

Full details: Microshift Test Compatibility

Explanation

PASS: The pull request only removes the limits.memory: 4Gi entries from two CI YAML files. The diff adds no Ginkgo tests and references no MicroShift-incompatible APIs or features. The custom check is therefore not applicable.

Full details: Single Node Openshift (Sno) Test Compatibility

Explanation

PASS: The pull request changes only two CI YAML files. It removes limits.memory: 4Gi from resource profiles and adds no Ginkgo tests or test constructs such as It(), Describe(), Context(), or When(). Therefore, the SNO test-compatibility check is not applicable.

Full details: Topology-Aware Scheduling Compatibility

Explanation

PASS: The pull request changes only two ci-operator YAML resource profiles. The diff removes limits.memory: 4Gi from the '*' CI resource entry and keeps the requests unchanged. It does not modify deployment manifests, operator code, or controllers, and it introduces none of the listed topology scheduling constraints.

Full details: Ote Binary Stdout Contract

Explanation

PASS. The commit changes only two CI YAML files. It removes limits.memory: 4Gi from the default resource profile in each file. The diff introduces no OTE binary code, process-level setup, logging, or stdout write. Therefore, it does not introduce the stated JSON-on-stdout contract failure.

Full details: Ipv6 And Disconnected Network Test Compatibility

Explanation

PASS: The pull request changes only two CI YAML resource profiles. It removes limits.memory: 4Gi from the '*' resource entry in the pf4 and pf5 configurations. The commit adds no Ginkgo tests, test files, network code, URLs, IP addresses, or connectivity behavior. Therefore, this custom check is not applicable.

Full details: No-Weak-Crypto

Explanation

PASS. The pull request changes only two CI YAML files. It removes memory resource limits from the pf4 and pf5 profiles. The patch introduces no MD5, SHA1, DES, RC4, 3DES, Blowfish, ECB, custom crypto, or secret-comparison code.

Full details: Container-Privileges

Explanation

PASS: The pull request changes only two CI YAML files. The diff removes limits.memory: 4Gi from resource entries. It adds no privileged, host namespace, SYS_ADMIN, allowPrivilegeEscalation, root-user, or capability settings.

Full details: No-Sensitive-Data-In-Logs

Explanation

The pull request changes only resource limits in two CI YAML files. The diff removes limits.memory: 4Gi and adds no logging, credentials, identifiers, hostnames, or customer data. The custom check does not identify a sensitive-data logging issue.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Amoghrd
Once this PR has been reviewed and has the lgtm label, please assign jpinsonneau for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• ci-operator/config/netobserv/netobserv-web-console/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Amoghrd]

/assign @jpinsonneau

[openshift-merge-bot]

[REHEARSALNOTIFIER]
@Amoghrd: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
pull-ci-netobserv-netobserv-web-console-main-pf4-pf4-images	netobserv/netobserv-web-console	presubmit	Ci-operator config changed
pull-ci-netobserv-netobserv-web-console-main-pf4-pf4-integration-tests	netobserv/netobserv-web-console	presubmit	Ci-operator config changed
pull-ci-netobserv-netobserv-web-console-main-pf4-pf4-plugin-cypress	netobserv/netobserv-web-console	presubmit	Ci-operator config changed
pull-ci-netobserv-netobserv-web-console-main-pf5-pf5-images	netobserv/netobserv-web-console	presubmit	Ci-operator config changed
pull-ci-netobserv-netobserv-web-console-main-pf5-pf5-integration-tests	netobserv/netobserv-web-console	presubmit	Ci-operator config changed
pull-ci-netobserv-netobserv-web-console-main-pf5-pf5-plugin-cypress	netobserv/netobserv-web-console	presubmit	Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

[Amoghrd]

/pj-rehearse pull-ci-netobserv-netobserv-web-console-main-pf5-pf5-images

[openshift-merge-bot]

@Amoghrd: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[Amoghrd]

/pj-rehearse pull-ci-netobserv-netobserv-web-console-main-pf5-pf5-plugin-cypress

[openshift-merge-bot]

@Amoghrd: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[openshift-merge-bot]

@Amoghrd: job(s): either don't exist or were not found to be affected, and cannot be rehearsed

[Amoghrd]

/pj-rehearse pull-ci-netobserv-netobserv-web-console-main-pf4-pf4-images

[openshift-merge-bot]

@Amoghrd: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[openshift-ci]

@Amoghrd: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[Amoghrd]

/pj-rehearse ack

[openshift-merge-bot]

@Amoghrd: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.