Add Azure v7 instance type spot check jobs for OCP 5.0 - #84317
Conversation
Adds e2e-azure-*-ovn-upgrade periodic jobs for 17 Azure v7 instance types: Ddsv7, Dsv7, Dadsv7, Daldsv7, Dalsv7, Dasv7, Dldsv7, Dlsv7, Esv7, Eadsv7, Easv7, Fadsv7, Faldsv7, Falsv7, Famdsv7, Famsv7, Fasv7 Each job tests the e2e upgrade workflow on a specific instance type, using @monthly cron schedule for spot checking. Instance types are configured via COMPUTE_NODE_TYPE and CONTROL_PLANE_INSTANCE_TYPE environment variables. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com> rh-pre-commit.version: 2.4.0 rh-pre-commit.check-secrets: ENABLED
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review. WalkthroughAdded 17 monthly Azure OVN upgrade conformance jobs for Standard_D, Standard_E, and Standard_F v7 Azure VM variants. Each job enables core-dump failure handling and defines variant-specific compute and control-plane instance types. ChangesAzure OVN upgrade jobs
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This change adds scheduled Azure v7 spot-check jobs and their generated configuration; no actionable merge-blocking risk remains beyond normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.) Full details: Stable And Deterministic Test NamesExplanation The pull request changes only CI YAML and generated Prow configuration. The diff adds 17 fixed job names and matching fixed Prow targets. It adds no Ginkgo title calls such as Full details: Test Structure And QualityExplanation PASS: The pull request changes only two YAML configuration files. The diff adds 17 Prow job definitions and generated periodic-job entries. It adds no Ginkgo test code or test blocks, so the single-responsibility, setup/cleanup, timeout, assertion-message, and test-pattern requirements are not applicable. Full details: Microshift Test CompatibilityExplanation PASS: The pull request adds only CI YAML and generated Prow configuration. The HEAD-versus-parent diff contains no Go or other Ginkgo test declarations, and added-line searches found no It(), Describe(), Context(), or When() calls. Therefore, the MicroShift test-compatibility check is not applicable. Full details: Single Node Openshift (Sno) Test CompatibilityExplanation PASS — The pull request changes only two CI YAML files. The diff adds 17 periodic job definitions and generated Prow entries that invoke the existing Full details: Topology-Aware Scheduling CompatibilityExplanation PASS: The pull request changes only CI configuration files: Full details: Ote Binary Stdout ContractExplanation The pull request changes only two YAML files: the release job configuration and generated Prow periodic jobs. The added entries configure monthly Azure OVN upgrade jobs and invoke Full details: Ipv6 And Disconnected Network Test CompatibilityExplanation PASS: The pull request changes only two YAML configuration files. The diff adds Azure periodic job declarations and generated Prow entries; it adds no Ginkgo tests or Go files. Therefore, this custom check is not applicable. Full details: No-Weak-CryptoExplanation PASS: The pull request adds only YAML job and generated Prow configuration. The added content defines Azure instance types, schedules, environment variables, observers, and references the existing Full details: Container-PrivilegesExplanation PASS. The pull request changes only Azure CI job definitions and generated Prow job manifests. The 17 new job blocks contain scheduling, labels, environment variables, workflow targets, service-account/secret wiring, and standard resource fields. They do not add Full details: No-Sensitive-Data-In-LogsExplanation PASS: The commit adds only Azure CI job configuration and generated Prow entries. The new source block (lines 418–626) contains schedules, Azure VM types, test settings, and a workflow reference. It contains no logging commands, credentials, tokens, hostnames, or customer data. The generated entries contain only standard secret-volume references and job arguments; they do not contain secret values. The referenced Azure workflow and setup logging are unchanged, and the logged instance types and region are not sensitive data under this check. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sdodson The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
|
[REHEARSALNOTIFIER]
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals. Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse max |
|
@sdodson: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@sdodson: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Superseded by PR #84318 which uses install jobs instead of upgrade jobs |
1 participant
Summary
Adds periodic spot check jobs for 17 Azure v7 instance types:
Each job tests the e2e upgrade workflow on a specific instance type with a @monthly schedule.
Implementation
Test plan
All jobs can be rehearsed before merge:
🤖 Generated with Claude Code
Summary by CodeRabbit
Adds 17 monthly Azure v7 spot check jobs for OCP 5.0. The jobs run the
openshift-upgrade-azure-ovnworkflow for D, E, and F VM families.Each job sets
COMPUTE_NODE_TYPEandCONTROL_PLANE_INSTANCE_TYPE, uses the Azure cluster profile, and fails on core dumps. The changes add the CI job definitions and generated Prow configurations. Maintainers can rehearse the jobs before merge to verify configuration and scheduling.