NVIDIA-1170: Add signed job(s) - #84324
Conversation
Signed-off-by: Jose Castillo Lema <josecastillolema@gmail.com>
gitleaks.version: 8.30.0
gitleaks.check-secrets: ENABLED
openshift-ci-robot
added
the
jira/valid-reference
|
@josecastillolema: This pull request references NVIDIA-1170 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.1.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
Bot
added
the
approved
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Team Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review. WalkthroughThe AWS workflow now accepts a precompiled-driver setting. The 4.22 stable configuration adds a signed NVIDIA GPU Operator test job with secure boot and precompiled drivers enabled. ChangesSigned NVIDIA GPU Operator end-to-end test
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to The change adds signed NVIDIA CI job configuration and workflow wiring, with no actionable merge-blocking risk remaining; it is merge-ready after normal checks and review. 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.) Full details: Stable And Deterministic Test NamesExplanation PASS. The pull request changes CI YAML only. It adds the static target Full details: Test Structure And QualityExplanation PASS: The pull request changes only CI YAML configuration and generated Prow job YAML. The diff adds a signed NVIDIA GPU Operator job and declares Full details: Microshift Test CompatibilityExplanation PASS: The pull request adds CI configuration and one workflow environment variable, not new Ginkgo test declarations. The exact diff contains only YAML files; it adds the Full details: Single Node Openshift (Sno) Test CompatibilityExplanation PASS — The pull request adds CI YAML only. The diff adds the Full details: Topology-Aware Scheduling CompatibilityExplanation PASS: The pull request changes only CI job configuration, a generated presubmit job, and a workflow environment-variable declaration. The diff adds no deployment manifest, operator code, controller, or scheduling constraint. The existing workflow replica settings remain unchanged, and the added job uses the existing Full details: Ote Binary Stdout ContractExplanation PASS. The commit changes only three YAML files. It adds a signed CI job, a generated presubmit entry, and an environment-variable declaration. The diff contains no OTE source, main or suite setup code, logging calls, or stdout writes. The new job invokes the existing Full details: Ipv6 And Disconnected Network Test CompatibilityExplanation PASS. The pull request adds CI YAML only: a signed variant of the existing Full details: No-Weak-CryptoExplanation The pull request adds CI YAML for a signed Secure Boot job and declares NVIDIAGPU_USE_PRECOMPILED_DRIVER. The commit adds no MD5, SHA1, DES, 3DES, RC4, Blowfish, or ECB usage. It adds no crypto implementation or secret/token comparison. The added job only selects existing Secure Boot steps and a precompiled-driver option. Full details: Container-PrivilegesExplanation PASS. The pull request adds one CI job and one optional environment variable. The exact diff introduces no Full details: No-Sensitive-Data-In-LogsExplanation PASS. The pull request adds a CI job, environment values, a workflow parameter declaration, and generated Prow configuration. It does not add logging code or log interpolation of secrets, tokens, credentials, PII, or customer data. The new reporter template is identical to the existing template and reports only job status and a log URL. The added environment values are the literals "true", "v26.3", and an existing base domain; none is logged by the changed files. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[REHEARSALNOTIFIER]
A total of 46 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse pull-ci-rh-ecosystem-edge-nvidia-ci-main-4.22-stable-nvidia-gpu-operator-e2e-26-3-x-signed |
|
@josecastillolema: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse ack |
|
@josecastillolema: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-merge-bot
Bot
added
the
rehearsals-ack
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: josecastillolema, vtruhpon The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@josecastillolema: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
I think we should go with the newest GPU Operator version 26.7. Otherwise, LGTM. |
Totally @nikitabugrovsky , this PR was just for validating the e2e workflow, will open a new one including all the missing targets from OCP 4.20 onward. |
|
@nikitabugrovsky continued in #84407 |
4 participants
Summary by CodeRabbit
NVIDIAGPU_USE_PRECOMPILED_DRIVER.